-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voxel descriptors - problem with assigning atom types to SmallMol #5
Comments
Hi Larry, I'll look into it the coming week. Thanks for the report :) |
From the code side it looks fine. If you have VMD use this code to visualize the features in VMD, and also use SmallMolLib if you want. from moleculekit.smallmol.smallmol import SmallMol
from moleculekit.smallmol.smallmollib import SmallMolLib
from moleculekit.tools.voxeldescriptors import getVoxelDescriptors, viewVoxelFeatures
import matplotlib.pyplot as plt
from mpl_toolkits.mplot3d import axes3d
# read molecule
suppl = SmallMolLib("GDP_ideal.sdf")
mol = suppl[0]
# generate voxels
features, centers, N = getVoxelDescriptors(mol,
boxsize=(18, 16, 16),
voxelsize=0.5,
center=mol.getCenter())
viewVoxelFeatures(features, centers, N, voxelsize=0.5)
mol.view(style='Licorice') As for the hydrophobicity and negative ionizable, @cuzzo87 will have to chime in as I'm no chemist. I assume it's an issue of rdkit though as you said |
According to @cuzzo87 it's an rdkit issue since it can only return one descriptor/feature per atom. This means that an atom can be either hydrophobic or aromatic but not both. This is not something we can correct easily. But from an ML point of view it might not matter in the end as long as it's consistently putting atoms into one category. |
Hi @stefdoerr @cuzzo87 thanks for looking into into this issue. I agree this should not be a problem for ML. |
I will close this as we are not planning to modify rdkit. Thanks for the input! |
Hi devs,
Before you get the documentations ready, I tried to figure out how to generate voxel descriptors for my small molecules myself. I used this molecule from the PDB as a test. Below is the code:
Most of the channels generated by this code look fine, but
hydrophobic
andnegative_ionizable
channels are completely empty. This does not make sense chemically, since at least some carbon atoms on the guanine and ribose rings should be considered hydrophobic, and the hydroxyls on the phosphates are definitively negatively ionizable.I noticed when a
SmallMol
object is passed intogetVoxelDescriptors
, the function calls_getPropertiesRDkit
, which in turn calls some RDKit functions to assign properties to atoms. I tried to print thechannels
array generated by this function, and it looked like all atoms are assigned zeros forhydrophobic
andnegative_ionizable
channels.Did I do this wrong, or is this an issue with RDKit? Thank you
The text was updated successfully, but these errors were encountered: