Add - AIM-120 and Doppler seeker

[TheCandianVendingMachine]

When merged this pull request will:

• Add Doppler seeker type
• Add AIM-120

Merge Strategy

Follow #10019

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[johnb432]

Is there a specific reason why these aren't alphabetically sorted?

[johnb432]

Suggested change

	z\ace\addons\aim120
	z\ace\addons\aim120

[johnb432]

Personal preference.

Suggested change

	*/
	*/

[johnb432]

Why not use objNull instead?
If we miss a isNil check somewhere further down, it could break things.

[johnb432]

Both statements are always going to be true.

Suggested change

	TRACE_2("dont filter helicopters",_target isKindOf "Helicopter",isEngineOn _target);
	TRACE_1("dont filter helicopters",_target);

[johnb432]

Suggested change

	private _shooterHasActiveRadar = {
	if ("ActiveRadarSensorComponent" in _x) exitWith { true };
	false
	} forEach listVehicleSensors vehicle _shooter;
	private _shooterHasActiveRadar = (listVehicleSensors _vehicle) findIf {"ActiveRadarSensorComponent" in _x} != -1;

If we can't guarantee that "ActiveRadarSensorComponent" is always going to be written in that case, we'd need to use this instead:

private _shooterHasActiveRadar = (listVehicleSensors _vehicle) findIf {_x findIf {_x == "ActiveRadarSensorComponent"} != -1} != -1;

Might be able to do something with flatten, but it's usually expensive in terms of performance.

[johnb432]

This should account for a number instead of a string (e.g. 24 in config).

Suggested change

	private _blocking = configOf _x >> "weaponLockSystem";
	private _isChaff = false;
	if (isNumber _blocking) then {
	_isChaff = (8 == getNumber _blocking);
	};
	if (isText _blocking) then {
	_isChaff = ("8" in getText _blocking);
	};
	private _isChaff = ([getNumber (configOf _x >> "weaponLockSystem"), 4] call EFUNC(common,binarizeNumber)) select 3;

[johnb432]

I like using lazy-eval to my advantage and imo here it would be a good idea to use it.

Suggested change

	(_withinView && _canSee && _isChaff)
	(([getNumber (configOf _x >> "weaponLockSystem"), 4] call EFUNC(common,binarizeNumber)) select 3) && // Check if chaff can break radar lock
	{[_projectile, getPosASLVisual _x, _seekerAngle] call FUNC(checkSeekerAngle)} && // Check if within view
	{[_projectile, _x, false] call FUNC(checkLos)} // Check if can be seen

[johnb432]

If the default is the default that is gotten with getX, then use getX directly. CBA_fnc_getConfigEntry is about 2-3x more expensive in terms of performance, so imo only use when needed.

Suggested change

	private _projectileThrust = [_projectileConfig >> "thrust", "NUMBER", 0] call CBA_fnc_getConfigEntry;
	private _projectileThrustTime = [_projectileConfig >> "thrustTime", "NUMBER", 0] call CBA_fnc_getConfigEntry;
	private _projectileThrust = getNumber (_projectileConfig >> "thrust");
	private _projectileThrustTime = getNumber (_projectileConfig >> "thrustTime");