-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missileguidance -- rewrite to use real-world guidance principles, general refactor #10019
Open
TheCandianVendingMachine
wants to merge
278
commits into
master
Choose a base branch
from
missile_guidance_rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
Open
This was referenced May 28, 2024
Open
PabstMirror
reviewed
May 30, 2024
addons/missileguidance/functions/fnc_navigationType_zeroEffortMiss.sqf
Outdated
Show resolved
Hide resolved
LinkIsGrim
reviewed
Jun 18, 2024
Comment on lines
+12
to
+14
|
||
GVAR(dev_fnc_projectileCamera) = compile preprocessFileLineNumbers QPATHTOF(dev\projectileCamera.sqf); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
GVAR(dev_fnc_projectileCamera) = compile preprocessFileLineNumbers QPATHTOF(dev\projectileCamera.sqf); | |
#ifdef ENABLE_PROJECTILE_CAMERA | |
GVAR(dev_fnc_projectileCamera) = compile preprocessFileLineNumbers QPATHTOF(dev\projectileCamera.sqf); | |
#endif | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now there is a gvar you can set for debugging info
if we're going to keep that then we should just move this into a standard prep(
LinkIsGrim
reviewed
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR, based on #8215
Overview
When merged this pull request will:
getPos
instead ofcenterOfMass
) which was moving at 100kmh at a distance of 2km at a firing angle of 90 degreesNavigation types:
Changes flight model of weapons to utilise in-engine calculations of velocity. This avoids issues where the missile will lose all of its energy and hang in the air. This also allows for "bang-bang" guidance weapons, such as the GBU-12.
Merge Strategy
In the linked project, all components labelled as “Necessary” must be merged at the same time; otherwise there will be broken components. “Supplementary” items are features which add new missiles to fully cover all vanilla systems, but otherwise are not breaking. “Nice to have” are features which were developed off of this branch, but are basically their own independent PR.
Misc
To-Do
Videos:
https://youtu.be/5MrPyqcZc0I
https://youtu.be/WF9K1GitV00
https://youtu.be/xXSJLwrJW1A
https://youtu.be/E9O9M5OcxdU
https://youtu.be/_v6BdAw-MA0