Add - SDB and GPS tracking #10037
Open
Add - SDB and GPS tracking #10037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1270d17.
TheCandianVendingMachine
changed the base branch from
master
to
missile_guidance_rewrite
13 tasks
rautamiekka
suggested changes
May 28, 2024
Comment on lines
+25
to
+29
| [ | ||
| GVAR(gps_currentSettings)#0, | ||
| GVAR(gps_currentSettings)#1, | ||
| GVAR(gps_currentSettings)#2 | ||
| ] |
There was a problem hiding this comment.
Should be replaceable like this, as per the command description & syntax 6 in the documentation:
Suggested change
| [ | |
| GVAR(gps_currentSettings)#0, | |
| GVAR(gps_currentSettings)#1, | |
| GVAR(gps_currentSettings)#2 | |
| ] | |
| +GVAR(gps_currentSettings) |
There was a problem hiding this comment.
What you're suggesting is a deep copy while original code basically does a shallow one, shallow copy would be [] + GVAR(gps_currentSettings). Does not seem to matter in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Merge Strategy
Follow #10019
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.