Wind deflection single pfeh #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _bulletSpeed = vectorMagnitude _bulletVelocity; | ||
|
|
||
| if ((!alive _bullet) || {(_bullet isKindOf "BulletBase") && {_bulletSpeed < 100}}) then { |
There was a problem hiding this comment.
(_bullet isKindOf "BulletBase")
We are checking this when we add the bullets to the array. Is it necessary to check it again here?
There was a problem hiding this comment.
We track either BulletBase or GrenadeBase
I think we still wanted to track 40mm grenades even if they're on a low speed ballistic path.
PabstMirror
added a commit
that referenced
this pull request
Jul 25, 2015
Wind deflection single pfeh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches fnc_updateTrajectoryPFH to be a master PFEH, bullets get added to an internal array instead of creating/deleting a new cba PFEH each time.
I believe this solves a big performance problem where the
count cba_common_perFrameHandlerArraycan grow too large.In actual session I saw it hit >2000. Most entries are nil, but it sill takes time to process them, which happens each frame. (2000 is about 5.5ms each frame),
In a stress test mission with about 50 ai + disabling the isPlayer check in handleFired so all AI bullets are tracked. Unscientific results because AI are unpredictable, but I get a huge performance difference:
VS
With PFEH debug enabled: