Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Vignette and Cleaned up UI component #2368

Merged
merged 4 commits into from Sep 28, 2015
Merged

Removed Vignette and Cleaned up UI component #2368

merged 4 commits into from Sep 28, 2015

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Sep 5, 2015

Separated from #1857

@jonpas jonpas mentioned this pull request Sep 5, 2015
18 tasks
@jonpas jonpas changed the title Remove Vignette and Cleanup UI component Removed Vignette and Cleaned up UI component Sep 6, 2015
@jonpas
Copy link
Member Author

jonpas commented Sep 22, 2015

Status?

@commy2
Copy link
Contributor

commy2 commented Sep 22, 2015

I'm for merging this. This thing will not be missed.

@commy2 commy2 added this to the 3.4.0 milestone Sep 22, 2015
@@ -9,3 +9,4 @@ Changes the chat contrast on the map to allow easier reading.
The people responsible for merging changes to this component or answering potential questions.

- [VKing](https://github.com/VKing6)
- [Jonpas](https://github.com/jonpas)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you can't add yourself as a maintainer here 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, that is left over from the bigger PR in which I am waiting for new commands that didn't make it into 1.50, I just cherry-picked. :)

@kymckay
Copy link
Member

kymckay commented Sep 22, 2015

👍 In favour

@jonpas
Copy link
Member Author

jonpas commented Sep 22, 2015

Good to go!

@@ -1 +0,0 @@
#include "\z\ace\addons\ui\script_component.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being deleted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, because there are no functions 👍 Nevermind 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍌

@thojkooi thojkooi added the kind/feature Release Notes: **ADDED:** label Sep 22, 2015
@thojkooi
Copy link
Contributor

👍

thojkooi added a commit that referenced this pull request Sep 28, 2015
Removed Vignette and Cleaned up UI component
@thojkooi thojkooi merged commit 7215dd9 into acemod:master Sep 28, 2015
@jonpas jonpas deleted the removeVignetteAndCleanUI branch September 28, 2015 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants