New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selective UI Elements #1857
Selective UI Elements #1857
Conversation
To all ACE3 devs, there is a slight problem I encountered, specifically UI elements such as command bar and peripheral dots seem to be hard-coded into the engine. They are not actually displays (no IDDs or IDCs in sub-classes), making it impossible to manipulate in SQF (correct?). I've been discussing on Slack about the approach, there really wasn't a perfect approach found, if they are completely hard-coded then the only way would be to decide what wants to be enabled and what disabled (in line with what ACE3 wishes to achieve), or remake those UI components so that we could toggle them. I tried adding IDD and IDC to one of them, and that doesn't do anything at all. Are there any other ideas that could work? What would be the best approach to all this? |
@jonpas Aren't the peripheral dots just a .paa file somewhere, could override it in the config to point to a blank/transparent or 1x1 pixel file? Not the cleanest solution ever but it should work. |
I want them togglable though, with settings framework. That is the point of the question. :) |
Ooh it may be indeed, thanks @SzwedzikPL ! (if not for anything else at least making sure what's hard-coded and what not. |
On hold until next Arma 3 update (above 2 commands). If you (core devs) want vignette removal now I can do that in separate PR. |
On hold further because |
Good to go i think. Can't wait to see optional Leader Command Bar :) |
Conflicts: addons/ui/README.md addons/ui/RscChat.hpp addons/ui/config.cpp
Implemented a ton of settings, came over 3 things to decide on, described below. I would rebase this thing but it contains merges from master, so I'll keep it rather, can make a new PR if wanted when I am finished, this is still WIP, searching through config takes it's time...
Ammo count when you are on foot is currently disabled in
Can only be disabled by config currently, I'd vote to disable it, it's just an annoyance, at least for how we play. FYI, this is the hexagon that shows on your Squad Leader when you look at him.
Will possibly be disabled in 1.54 considering this comment, if it won't be I vote disabling them via config as well, not possible via scrip. |
As discussed in Slack another suggestion: Option to disable/enable the chat. I suggest the following options:
|
This is feature-complete, there are most likely more UI elements that could be added, can always add them as we find them, it's a lot of looking up the config and then trial and error. Keeping a list in the PR comment to keep track. Also implemented a "setter", which is basically a public function through which other component should toggle UI elements to prevent UI component itself changing it again (as it has to be done on vehicle changes for example). As requested by @esteldunedain for his changes in scope adjustment (and FCS IIRC). Vehicle compass (or radar, can't remember) doesn't seem to do anything, but that works through |
[true] call FUNC(setElements); | ||
|
||
// On load and entering/exiting a vehicle | ||
["infoDisplayChanged", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonpas, where is this event raised from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nvm, it's hooked in ace_common already
Looks good. Should be merged asap for 3.6.0 I think |
Split UI configs-> Removed Vignette and Cleaned up UI component #2368Remove Vignette-> Removed Vignette and Cleaned up UI component #2368showHUD
parameters selective UIshowHud
setterToggle Iconsconfig-onlySquad Leader hexagon selective UIconfig-only, disabled on Elite difficultyPeripheral dots selective UIconfig-only, disabled on Regular+ difficultyChat windows selective UIconfig-onlyCrosshairconfig-onlyAdd "allow client to change" value to each setting, show it in client settings, don't allow changing those Enabled/Disabled in module/server settings-> 3DEN - ACE_Settings Display #3563Known issues:
showHud
)