-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup medical PFHs #3462
Merged
Merged
Cleanup medical PFHs #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop. Use waitAndExecute instead of a pfh for better performance.
nicolasbadano
added
status/WIP
kind/cleanup
Release Notes: **CHANGED:**
kind/optimization
Release Notes: **IMPROVED:**
labels
Feb 28, 2016
…in compatible with swapping localities
…to decrease when above 10
…of medications over time. Use waitAndExecute instead of a pfh for better performance.
nicolasbadano
changed the title
Rename and add comments to the function that tracks the units vital l…
Cleanup medical PFHs
Mar 1, 2016
I am happy with this 👍 |
Now I get this when starting the game:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My plan is to take a look at all the pfh loops in medical, comment them and clean them up. For those with long intervals, switch
addPerFrameHandler
forwaitAndExecute
.I'll also try collapsing all the loops that handle the evolution of treatments into the
vitalLoop
, for better performance, clarity and locality handling.unconsciousPFHChanges: