3DEN - ACE_Settings Display #3563
Conversation
| @@ -15,4 +15,50 @@ GVAR(serverSideValues) = []; | |||
| GVAR(categories) = []; | |||
| GVAR(currentCategorySelection) = 0; | |||
|
|
|||
| recomp = { | |||
There was a problem hiding this comment.
Any reason we use recomp without a prefix?
There was a problem hiding this comment.
This is just for development, recompiles all funcs before opening menu.
Makes testing very fast.
Will remove when PR is ready.
|
Added sub-categories, if not explictly defined they are generated from the var name of the setting.
|
|
That looks amazing |
|
👏👏👏 |
|
Impressive! 👍 |
PabstMirror
added
kind/enhancement
|
Should be good to review now, still want to move some settings to categories/subCategories, but that can be done on another PR |
| @@ -15,4 +15,55 @@ GVAR(serverSideValues) = []; | |||
| GVAR(categories) = []; | |||
| GVAR(currentCategorySelection) = 0; | |||
|
|
|||
|
|
|||
| [] spawn { | |||
| sleep 0.1; //is3den command has problems at pre-init, need spawn/sleep | |||
There was a problem hiding this comment.
Any reason we don't run this at post-init is pre-init has issues?
There was a problem hiding this comment.
Never mind - I just read the comment on line 24.
There was a problem hiding this comment.
execNextFrame is installed in postInit
There was a problem hiding this comment.
A lot of things are done on postinit. Doesn't that mean all these are now broken in 3den?
There was a problem hiding this comment.
postInit does fire when you press preview
There was a problem hiding this comment.
If that is the case - why are we doing a spawn here? Is this comment false:
//Post-init won't run in 3den, so we need to directly call some settings funcs normally run at common: post-init
There was a problem hiding this comment.
by "in 3den" he means while placing objects. postInit will fire once you press "preview", but not while you actually are in the editor.
|
@commy2 would you be able to give some input? This might be something for CBA settings framework perhaps? |
|
Leaving this open until we decide whatever or not we commit to using the CBA settings framework. If we do, this PR should be closed. Otherwise, it is good to go in. |
|
Redundant with move to CBA Settings. |
When merged this pull request will:
This adds another source of ace_settings, they should be loaded after mission config (description.ext) but before modules. Any setting set, will be forced set.
ToDo:
subCategory = "#hide";