Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fnc_getMapData.sqf #3977

Merged
merged 3 commits into from
Jun 25, 2016
Merged

Update fnc_getMapData.sqf #3977

merged 3 commits into from
Jun 25, 2016

Conversation

Laid3acK
Copy link
Contributor

@Laid3acK Laid3acK commented Jun 22, 2016

Add maps and fix latitude :

  • Kidal, latitude 18° (default latitude 0°)
  • Governor´s Island, latitude 41° (default latitude -34°)
  • Doung island (Unsung Mod), latitude 10° (default latitude -10°)
  • Dakrong (Unsung Mod), latitude 16° (default latitude -16°)
  • Pecher map, latitude 43° (default latitude -34°)
  • CWR2 maps included in the last CUP update

and fix my illiterate mistakes ...

Add maps and fix latitude :
 - Kidal, latitude 18° (default latitude 0°)
 - Governor´s Island, latitude 41° (default latitude -34°)
 - Doung island (Unsung Mod), latitude 10° (default latitude -10°)
 - Dakrong (Unsung Mod), latitude 16° (default latitude -16°)
 - Pecher map, latitude 43° (default latitude -34°)

Remove obsolete Arma2 Lingor map

and fix my illiterate mistakes ...
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jun 22, 2016
 - Add OFP maps by CWR2 team included in the last CUP terrains update
 - Fix latitude according to the Bohemia Wiki
if (_map in ["malvinas"]) exitWith { [-52, 0] };
if (_map in ["namalsk"]) exitWith { [65, 0] };
if (_map in ["mcn_aliabad"]) exitWith { [36, 0] };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to remove Namalsk?

Copy link
Contributor

@commy2 commy2 Jun 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not removed. List was sorted alphabetically. See L66 / L70

@Laid3acK
Copy link
Contributor Author

Namalsk was a part of my "illiterate mistakes" because in the alphabetic order, the letter "n" is after the letter "m" ... Except for me :P ... So, normally, Namalsk is not removed, but now in his correct place. Could you confirm that please ? (My knowledge about Github ...)

@nicolasbadano
Copy link
Contributor

Could you confirm that please

Yes, true. Sorry.

if (_map in ["koplic"]) exitWith { [42, 0] };
if (_map in ["kunduz"]) exitWith { [37, 0] };
if (_map in ["lingor", "lingor3"]) exitWith { [-4, 0] };
if (_map in ["lingor3"]) exitWith { [-4, 0] };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep "lingor"? Maybe there are builds of the map that use that name.

No Gitexit for Lingor. Stay with us Lingor ! :p
@Laid3acK
Copy link
Contributor Author

You are totally right, sorry for my mistake. :)

@commy2 commy2 added this to the 3.6.0 milestone Jun 25, 2016
@commy2 commy2 self-assigned this Jun 25, 2016
@commy2
Copy link
Contributor

commy2 commented Jun 25, 2016

merge? Haven't checked if the map names and these values are correct, but I trust J3aLeiNe : -)

@thojkooi thojkooi merged commit 2f627f5 into acemod:master Jun 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants