Spectator Improvements #5083
Merged
Spectator Improvements #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finally found out how to do this. Having search enabled on the unit tree might seem useful, but it doesn't interact well with keyboard shortcuts used for other purposes like camera control as it causes the tree to jump around unexpectedly.
Making good use of the new `select` CODE syntax.
- A `displayName` shown in the 3DEN multiplayer attributes display - A `respawnTypes` array to define which respawn types the template is compatible with (currently only includes `2,3` - need to investigate compatibility with other types further).
kymckay
added
kind/bug-fix
commy2
approved these changes
Apr 18, 2017
commy2
reviewed
Apr 18, 2017
| onPlayerKilled = QFUNC(respawnTemplate); | ||
| onPlayerRespawn = QFUNC(respawnTemplate); | ||
| respawnTypes[] = {2,3}; | ||
| }; |
There was a problem hiding this comment.
maybe disable conflicting templates in the eden ui?
There was a problem hiding this comment.
Wasn't aware there is a setting for that, will look into it
There was a problem hiding this comment.
There isn't afaik, but that has never stopped me. I just don't know which modes if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This can be merged now, but I'll leave it open for a little bit in case anyone wants to review.Forgot the new system requires a review from someone else 馃憤 It's been a while 馃槅