Use correct TransportX type for ace items #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kymckay
reviewed
May 17, 2017
addons/grenades/CfgVehicles.hpp
Outdated
| MACRO_ADDITEM(ACE_HandFlare_Red,12); | ||
| MACRO_ADDITEM(ACE_M84,12); | ||
| class TransportMagazines { | ||
| MACRO_ADDMAGAZINE(ACE_HandFlare_White,12); |
There was a problem hiding this comment.
Were these intentionally changed to white and green?
There was a problem hiding this comment.
No I had just copied the top set, thanks for catching
kymckay
reviewed
May 17, 2017
addons/grenades/CfgVehicles.hpp
Outdated
| MACRO_ADDITEM(ACE_HandFlare_Green,12); | ||
| MACRO_ADDITEM(ACE_M84,12); | ||
| class TransportMagazines { | ||
| MACRO_ADDMAGAZINE(ACE_HandFlare_White,12); |
|
lgtm, but what was the point again? |
|
I dunno, #5068 said it broke a script |
|
Think it's for consistency with vanilla |
kymckay
approved these changes
May 17, 2017
commy2
approved these changes
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5068
As far as I can tell arma can handle the wrong entries.
This does seem to put he mine detectors at the top of the "misc items" box, but I noticed no other changes.