Arsenal - Improvements to 3DEN attribute #6849
Conversation
| private _muzzleConfig = if (_x == "this") then {_weaponConfig} else {_weaponConfig >> _x}; | ||
|
|
||
| // Only add existent magazines and ensure correct classname case | ||
| private _magazines = getArray (_muzzleConfig >> "magazines") select {isClass (_cfgMagazines >> _x)}; |
There was a problem hiding this comment.
CBA_fnc_compatibleMagazines?
There was a problem hiding this comment.
We have to. For magazineWells.
Edit: oh I see magazinewells are handles manually...
Might be better perf wise. As we can just reference the magazineGroups that arsenal already has. Which is also done here.
There was a problem hiding this comment.
Can change to avoid duplicate code. Will need to test the performance difference for a large weapons list.
There was a problem hiding this comment.
I guess this does match code in fillRightPanel
cba func does cache results, but on first call it probably will be more expensive
There was a problem hiding this comment.
Did a quick test with ~400 weapons (RHS) and diag_tickTime, here are the results for the first and second clicks.
Current:
14:08:41 [ACE] (arsenal) INFO: Added compatible magazines (current) - Time: 36.9873 ms
14:09:05 [ACE] (arsenal) INFO: Added compatible magazines (current) - Time: 37.9944 ms
CBA_fnc_compatibleMagazines:
14:10:59 [ACE] (arsenal) INFO: Added compatible magazines (cba func) - Time: 67.0166 ms
14:11:13 [ACE] (arsenal) INFO: Added compatible magazines (cba func) - Time: 14.0076 ms
So not too big of a difference and this is also the extreme case of all weapons. Thoughts?
There was a problem hiding this comment.
Perf of both is fine for that.
CBA func uses additional memory for it's cache. But reduces code duplication.
So don't really know.
CBA func also filters out non existent magazines (which can occur in magazinewells) which you don't really do (configName will probably return "" so you'll have a bunch of empty strings)
Thinking about it. Does cache make so much sense for this? Do you really click that button that often? Most mission makers will probably make one arsenal object and then just copy it.
There was a problem hiding this comment.
The arsenal magazine wells cache also filters out non-existent magazines aswell: https://github.com/acemod/ACE3/blob/master/addons/arsenal/functions/fnc_scanConfig.sqf#L180
Yeah, the performance is fine for both (and I can't see the button being clicked very often). The slowest part is L72 which in the above situation takes 900-1000 ms.
There was a problem hiding this comment.
Don't really need to worry about 35ms if you have a 1000ms laying around a couple lines lower.
It really doesn't matter. Whatever you prefer. Less code duplication is the only reason that I have left as a reason to change this.
There was a problem hiding this comment.
Yeah, I think in that case it is fine as is.
|
Does the add compatible items button always set it to infinite? |
|
@Drofseh It just adds the items to the list, the mode controls whether the items added are whitelisted or blacklisted. |
* Improvements to arsenal 3DEN attribute * Better alignment of button * Remove magazineGroups copy
When merged this pull request will: