Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Feedback - fix heart rate effect #6927

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Conversation

PabstMirror
Copy link
Contributor

and limit setVar for acre/tfar (slightly less network traffic)

effectHeartbeat would recurse with no params
[FUNC(effectHeartBeat), [], _waitTime] call CBA_fnc_waitAndExecute;
so _heartbeat was undefined, this changes it to get the current HR each time the func is run

and limit setVar for acre/tfar
@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** ignore-changelog Release Notes: Excluded labels Apr 8, 2019
@PabstMirror PabstMirror added this to the Medical Rewrite milestone Apr 8, 2019
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check acre_main like we do in ace_common_fnc_endRadioTransmission.

@mharis001 mharis001 changed the title Medical Fedback - fix heart rate effect Medical Feedback - fix heart rate effect Apr 9, 2019
mharis001 and others added 2 commits April 9, 2019 00:23
Co-Authored-By: PabstMirror <pabstmirror@gmail.com>
@TheMagnetar TheMagnetar merged commit 69dc73e into master Apr 9, 2019
@TheMagnetar TheMagnetar deleted the mrFeedbackFixes branch April 9, 2019 17:52
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Medical Fedback - fix heart rate effect

and limit setVar for acre/tfar

* Apply suggestions from code review

Co-Authored-By: PabstMirror <pabstmirror@gmail.com>

* Update XEH_postInit.sqf

* use "task_force_radio"
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0, 3.13.0-temp3 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants