Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuel - Add events for start, stop and progress #7023

Merged
merged 6 commits into from
Oct 13, 2019

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented May 28, 2019

@synixebrett requested this.

ace_refuel_refuelTick might be renamed to just ace_refuel_tick ?
We also want a refuelDone event, but for that we need to store the amount of fuel that was transferred in the previous interaction.

I think local event is enough for this?

Todo:

  • Write documentation for eventhandlers

@jonpas
Copy link
Member

jonpas commented May 28, 2019

I think local event is enough for this?

Global would take a lot of network resources for something people might not even need.

@dedmen
Copy link
Contributor Author

dedmen commented May 28, 2019

There are many places where refueling might end.
And we'd need a variable and keep track of transferred fuel for a proper refuelEnded event.
Seems like maybe too much work?
Or we might aswell just do a refuelEnded that doesn't pass the total amount of transferred fuel as argument, if the user needs it. He can do that by himself by using the start/tick/end events.

@BrettMayson
Copy link
Member

This is going to be extremely niche, asking them to track the ticks isn't too much to ask imho

@Dystopian
Copy link
Contributor

ace_refuel_refuelTick might be renamed to just ace_refuel_tick

I vote for this. And other events too.

@PabstMirror PabstMirror added this to the 3.13.0 milestone Oct 13, 2019
@PabstMirror PabstMirror added area/documentation kind/enhancement Release Notes: **IMPROVED:** labels Oct 13, 2019
@PabstMirror PabstMirror changed the title Add events to refuel module Refuel - Add events for start, stop and progress Oct 13, 2019
@PabstMirror PabstMirror merged commit 3946928 into acemod:master Oct 13, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants