Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Status - Enable user input between death and respawn #7502

Merged
merged 4 commits into from
Feb 4, 2020

Conversation

Whigital
Copy link
Contributor

@Whigital Whigital commented Feb 1, 2020

When merged this pull request will:

  • Enables user input before respawn so that the respawn interface can be interacted with.

Addresses #7356

@commy2
Copy link
Contributor

commy2 commented Feb 1, 2020

lgtm

@commy2
Copy link
Contributor

commy2 commented Feb 1, 2020

still lgtm

@Whigital Whigital changed the title [medical_status] Enable user input before respawn [medical_status] Enable user input between death and respawn Feb 1, 2020
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix (approving on assumption from memory that the unconscious variable is reset on respawn rather than death) 👍

@Silentbytex
Copy link

Silentbytex commented Feb 2, 2020

So i have this respawn problem in arma 3 and while looking for a fix to the respawn freeze i reached here. However i have no idea nor experience with code so im very confused with what is presented here. I went to ace>addons>medicalstatus(i opened the pbo file with notepad) and then i'm at a deadend because i don't know what to do. Can anyone help me out?
edit: i noticed it's not notepad in the picture is it c++?

@commy2
Copy link
Contributor

commy2 commented Feb 2, 2020

This is a pull request, a change request to the code of ACE. After this pull request is merged and the next release published, the fix will be in the code of ACE.

You're lost and off topic.

i noticed it's not notepad in the picture is it c++?

No, SQF.

@Silentbytex
Copy link

Oh, ok. Thanks for the info.

@kymckay kymckay merged commit 3be84e9 into acemod:master Feb 4, 2020
@PabstMirror
Copy link
Contributor

What if _unit isn't player? (e.g. singleplayer)

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Feb 4, 2020
@PabstMirror PabstMirror added this to the 3.13.1 milestone Feb 4, 2020
@kymckay
Copy link
Member

kymckay commented Feb 4, 2020

Good point, not sure why that didn't cross my mind.

We could actually just replace the IS_UNCONSCIOUS condition with a check for whether the unit was the player to make sure input is always enabled on death. I think this should run for ACE_Player death not just player, right?

@commy2
Copy link
Contributor

commy2 commented Feb 5, 2020

Just player I believe.

@kymckay
Copy link
Member

kymckay commented Feb 5, 2020

Yeah think you're right on second thought, believe there may be a player changed EH somewhere which will already handle enabling input again if a remote controlled unit dies

@commy2
Copy link
Contributor

commy2 commented Feb 5, 2020

This should be fixed before a release.

@kymckay
Copy link
Member

kymckay commented Feb 5, 2020

#7510

@Whigital Whigital deleted the ace_medical_respawn branch February 11, 2020 17:17
@Whigital Whigital changed the title [medical_status] Enable user input between death and respawn Medical Status - Enable user input between death and respawn Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants