Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroDAGR - Improve item model #7838

Merged
merged 4 commits into from
Aug 6, 2020
Merged

MicroDAGR - Improve item model #7838

merged 4 commits into from
Aug 6, 2020

Conversation

bux
Copy link
Member

@bux bux commented Aug 3, 2020

When merged this pull request will:

  • use the correct dimensions from the microDAGR technical document
  • simplified model

20200803094150_1
thicc

20200803132940_1

And, yes, the screen is turned off.

bux added 3 commits August 3, 2020 12:18
(2 renames because of change in case (MicroDAGR -> microdagr)
@bux bux added the kind/enhancement Release Notes: **IMPROVED:** label Aug 3, 2020
@PabstMirror PabstMirror added this to the 3.13.4 milestone Aug 3, 2020
… alignment when placing or dropping the microdagr
@BaerMitUmlaut
Copy link
Member

The brand logo is probably copyrighted, could you replace it with a mock? Maybe something silly like RockmyCojones?

@bux
Copy link
Member Author

bux commented Aug 5, 2020

We already use the logo since ever:
https://forums.ahoyworld.net/uploads/monthly_2017_08/microDagr.png.736c1be2ef50997d9b5aa858323a4491.png

@BaerMitUmlaut
Copy link
Member

Ah right. Fine by me then. We can still change it if it becomes an issue.

@PabstMirror PabstMirror merged commit 9ef4371 into master Aug 6, 2020
@PabstMirror PabstMirror deleted the mdagr branch August 6, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants