-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Treatment - Add Additional Conditions for PAK Use #8964
Medical Treatment - Add Additional Conditions for PAK Use #8964
Conversation
Personal Aid Kits now have additional optional conditions for use: - Minimum Blood Level - Minimum Heart Rate - Patient must not be in pain - Patient must have no open wounds - Patient must have no open or bandaged wounds (Must be fully stitched) Co-Authored-By: André Vennberg <andre.vennberg@gmail.com>
It seems reasonable to give mission makers more control over the "embedded" aspects of ACE's medical system. Without PRs like these, communities have to resort to making in-house mods to expose the underlying features as CBA options. Which is fine if you only have to do this for one mod, but repeat that process a few times and your addon dependency graph quickly becomes more intricate than the lineage of the British royal family. Jokes aside - I appreciate your dedication for keeping this submission going, and hope this gets more attention this time! 🤞 |
As a missionmaker I would very much appreciate this being added, since currently I don't give out PAKs since it represents an "auto-heal" button in an otherwise pretty realistic representation of how med-care should work. |
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
// Untreated fractures have a value of 1. Treated are -1. | ||
if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { ((GET_FRACTURES(_unit) findIf {_x isEqualTo 1}) != -1) }) exitWith {false}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an additional option to allow fractures to prevent PAK use.
…m/dgibso29/ACE3 into Feature/Additional-PAK-Conditions
Current state of PR has been successfully tested on dedicated server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What little I know about ACE's workings it's good, I'll leave the rest to others.
@rautamiekka Just bumping this as it seems to be falling under the radar. Thanks for any context you can provide. |
@veteran29 Apologies for the ping, but you have been active in the repository recently and am trying to get movement on this PR. These changes have been approved in the past and gone through several rounds of feedback from @mharis001, but it seems to be falling under the radar since. Thanks! |
if (EGVAR(medical_treatment,allowPainPAK) == 0 && { IS_IN_PAIN(_unit) }) exitWith {false}; | ||
|
||
// Untreated fractures have a value of 1. Treated are -1. | ||
if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { ((GET_FRACTURES(_unit) findIf {_x isEqualTo 1}) != -1) }) exitWith {false}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { ((GET_FRACTURES(_unit) findIf {_x isEqualTo 1}) != -1) }) exitWith {false}; | |
if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && {1 in (GET_FRACTURES(_unit))}) exitWith {false}; |
Minor optimization.
if (_requiredWoundState == PAK_REQ_OPEN) exitWith {true}; | ||
|
||
// Parameterize this value to reduce duplication. | ||
private _hasOpenWounds = (GET_OPEN_WOUNDS(_unit) findIf {_x select 2 > 0 && {_x select 3 > 0}}) != -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be updated for #8926.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be moved to its own category, but out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of these setting titles.
<English>Required Wound State PAK</English> | ||
</Key> | ||
<Key ID="STR_ACE_Medical_Treatment_RequiredWoundStatePAK_Description"> | ||
<English>Controls whether a patient's wounds must be bandaged or stitched in order to use a PAK.</English> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<English>Controls whether a patient's wounds must be bandaged or stitched in order to use a PAK.</English> | |
<English>Controls whether a patient's wounds must be bandaged or stitched in order to use a Personal Aid Kit.</English> |
) exitWith {false}; | ||
|
||
private _requiredBloodVolume = DEFAULT_BLOOD_VOLUME * (EGVAR(medical_treatment,minBloodPAK) / 100); | ||
if (GET_BLOOD_VOLUME(_unit) < _requiredBloodVolume) exitWith {false}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'd be more intuitive if it used qualitative blood loss (hemmorhage class, "Lost some/a lot of/etc blood") instead.
@@ -176,6 +176,14 @@ Self IV Transfusion: See "Self PAK Usage". | |||
|
|||
Time Coefficient PAK: This setting controls how long a PAK takes to apply. Set to higher values to increase, lower to decrease. PAK has a minimum of 10 seconds usage time. | |||
|
|||
Required Wounds State PAK: Controls whether a patient's wounds must be bandaged or stitched in order to use a PAK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Wounds State PAK: Controls whether a patient's wounds must be bandaged or stitched in order to use a PAK. | |
Required Wounds State PAK: Controls whether a patient's wounds must be bandaged or stitched in order to use a Personal Aid Kit. |
@@ -176,6 +176,14 @@ Self IV Transfusion: See "Self PAK Usage". | |||
|
|||
Time Coefficient PAK: This setting controls how long a PAK takes to apply. Set to higher values to increase, lower to decrease. PAK has a minimum of 10 seconds usage time. | |||
|
|||
Required Wounds State PAK: Controls whether a patient's wounds must be bandaged or stitched in order to use a PAK. | |||
|
|||
Allow Pain PAK: Controls whether PAKs can be used on patients in pain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow Pain PAK: Controls whether PAKs can be used on patients in pain. | |
Allow Pain PAK: Controls whether Personal Aid Kits can be used on patients in pain. |
|
||
Allow Pain PAK: Controls whether PAKs can be used on patients in pain. | ||
|
||
Min Blood PAK: Minimum blood volume percentage required to use a PAK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Min Blood PAK: Minimum blood volume percentage required to use a PAK. | |
Min Blood PAK: Minimum blood volume percentage required to use a Personal Aid Kit. |
|
||
Min Blood PAK: Minimum blood volume percentage required to use a PAK. | ||
|
||
Min Heart Rate PAK: Minimum heart rate required to use a PAK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Min Heart Rate PAK: Minimum heart rate required to use a PAK. | |
Min Heart Rate PAK: Minimum heart rate required to use a Personal Aid Kit. |
Kindly, after nearly 3 years of trying to get this merged, it is no longer worth redeveloping this yet again versus maintaining an override in our framework. |
When merged this pull request will:
Personal Aid Kits now have additional optional conditions for use:
This PR is an attempt to resuscitate the work done in stale PR #7684, which was created prior to major build pipeline changes. The actual feature work has been recreated and re-tested here.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.