Medical - Add more conditions on when the PAK can be used (#7682) #7684

anden3 · 2020-05-05T15:42:58Z

When merged this pull request will:

Add an option to set minimum blood and heart rate levels for being able to use a PAK.
Add an option to not allow PAKs when the patient is in pain.
Add an option to set how patched up the patient needs to be before using a PAK:
- Patient has open wounds but is not bleeding (via tourniquets).
- Patient has bandaged wounds.
- Patient has stitched wounds.

addons/medical_treatment/initSettings.sqf

addons/medical_status/functions/fnc_isInStableCondition.sqf

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>

addons/medical_status/functions/fnc_isInStableCondition.sqf

- Removed unnecessary whitespace on LN 46 - Call global var directly at LN 87 - Updated Wound Reopen Chance localized name & description

- Increased reopen coefficient upper limit from 2 to 5.

PabstMirror · 2020-06-13T20:12:47Z

Is this still WIP or ready?

anden3 · 2020-06-13T20:50:39Z

Haven't gotten around to testing it in a multiplayer environment yet unfortunately.

LuizBarros99 · 2020-06-15T21:03:05Z

When merged this pull request will:

Add an option to set minimum blood and heart rate levels for being able to use a PAK.

Add an option to not allow PAKs when the patient is in pain.

Add an option to set how patched up the patient needs to be before using a PAK:

Patient has open wounds but is not bleeding (via tourniquets).

Patient has bandaged wounds.

Patient has stitched wounds.

Please add a setting to not allow PAKs when the patient has untreated fractures.

mharis001 · 2021-06-08T16:57:02Z

addons/medical_status/functions/fnc_isInStableCondition.sqf

+
+
+// Require stitched wounds.
+if (EGVAR(medical_treatment,requiredWoundStatePAK) == 2 && { !(count GET_OPEN_WOUNDS(_unit) ==  count GET_STITCHED_WOUNDS(_unit)) }) exitWith {false};


For similar reasons as the "require at least bandaged wounds" check, I think this can also fail. I think you just want to check that there are no bandaged wounds with amount > 0. reference

mharis001 · 2021-06-08T16:57:12Z

addons/medical_status/functions/fnc_isInStableCondition.sqf

+if (GET_BLOOD_VOLUME(_unit) < _requiredBloodVolume) exitWith {false};
+
+if (EGVAR(medical_treatment,allowPainPAK) == 0 && { IS_IN_PAIN(_unit) }) exitWith {false};
+if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { !(GET_FRACTURES(_unit) isEqualTo []) }) exitWith {false};


Use isNotEqualTo.

mharis001 · 2021-06-08T16:59:12Z

addons/medical_status/functions/fnc_isInStableCondition.sqf

+if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { !(GET_FRACTURES(_unit) isEqualTo []) }) exitWith {false};
+
+// Require at least bandaged wounds.
+if (EGVAR(medical_treatment,requiredWoundStatePAK) == 1) then {


I think you also want to check this when stitched wounds are required.

dgibso29 · 2021-06-14T12:11:45Z

Thanks for the review. I will get to this when able.

dgibso29 · 2021-08-16T19:20:45Z

I don't expect to be able to make time for this any time soon due to work. All help is appreciated in making the minor changes required for this PR to be approved & merged. Thanks.

This reverts commit 0f46553, reversing changes made to b30de99.

dgibso29 · 2022-01-05T01:53:50Z

Latest review changes addressed in anden3#5 and awaiting merge.

…ounds.

dgibso29 · 2022-01-05T02:26:55Z

One question: I've updated the default requiredWoundStatePAK to reflect current behaviour: Bandaged wounds required.

However, I've long felt that PAKs bypassing stitching effectively makes stitching redundant, and player behaviour in my community has reinforced that.

@mharis001 -- Do you feel that stitched wounds should be required for PAK application by default?

…ted successfully.

mharis001 · 2022-01-05T03:18:46Z

I think the default should reflect the behaviour prior to these settings being added.

rautamiekka · 2022-01-05T08:22:19Z

However, I've long felt that PAKs bypassing stitching effectively makes stitching redundant, and player behaviour in my community has reinforced that.

@mharis001 -- Do you feel that stitched wounds should be required for PAK application by default?

My 2c:

Let the community choose if they wanna go such ultra-realistic by introducing a setting, just like the options which only allow stitching in a medical vehicle, cuz I think having to stitch+PAK is ridiculously tedious in the long run.

And create rules in the community and make the settings accordingly !

For ex in our group, it varies between medics how they use both: some will postpone both until it's quiet (which is a mistake a lotta the time) but 99% the time will just PAK when it's quiet, I use PAK every time the action or man shortage ain't too bad compared to how long PAKking takes, and I use stitching only if either PAK takes way too long due to bruises or something, or the patient is unconscious and in a dangerously bad condition. Hell, a lotta the time we don't have stitching available.

^ Besides, you could require the use of medical facilities for stitching like we use the FSG Medic Bag from Workshop, which forces the medic (and mission maker) to think further.

Hopefully finishing this PR once and for all...

dgibso29 · 2022-01-19T17:37:47Z

@mharis001 Changes merged in from fork. Please review when able.

Build failure appears related to the changes in the build process since this PR was opened? My changes should not be causing them.

dgibso29 · 2022-05-24T23:45:55Z

@PabstMirror Any update on this? I've addressed all requested changes, but, due to the build pipeline changes, I cannot proceed without guidance from the curation team. This is further complicated by not being the author of the PR. Any and all help in finally getting this PR merged is greatly appreciated.

Thank you.

dgibso29 · 2022-06-23T13:53:50Z

@PabstMirror Any update on this? I've addressed all requested changes, but, due to the build pipeline changes, I cannot proceed without guidance from the curation team. This is further complicated by not being the author of the PR. Any and all help in finally getting this PR merged is greatly appreciated.

Thank you.

Apologies for bothering again, but, see above. I cannot proceed without assistance. @mharis001 as well.

Co-Authored-By: André Vennberg <andre.vennberg@gmail.com>

dgibso29 · 2022-07-12T14:04:37Z

I have rebuilt this PR's work into a clean and working state in #8964.

anden3 · 2022-07-19T21:24:30Z

Closed due to being succeeded by #8964.

andre-uncloudy and others added 3 commits May 5, 2020 14:12

Added settings and edited PAK condition.

572cf4b

Changed the setting to have several levels of wound states required.

d5400f6

Added author and removed logging.

9a26796

jonpas added the kind/enhancement Release Notes: **IMPROVED:** label May 5, 2020

jonpas added this to the 3.13.3 milestone May 5, 2020

jonpas added kind/feature Release Notes: **ADDED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels May 5, 2020

PointForward mentioned this pull request May 5, 2020

Disable PAK when limb is only tourniqueted, but not bandaged #7682

Closed

commy2 reviewed May 5, 2020

View reviewed changes

addons/medical_treatment/initSettings.sqf Outdated Show resolved Hide resolved

Changed setting functions.

b1ee72a

veteran29 requested changes May 5, 2020

View reviewed changes

addons/medical_status/functions/fnc_isInStableCondition.sqf Outdated Show resolved Hide resolved

anden3 and others added 3 commits May 5, 2020 20:56

Remove unnecessary whitespace

0dc1f59

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>

Combined some conditionals.

b44c722

Merge branch 'master' of github.com:anden3/ACE3

8aebdfa

commy2 reviewed May 5, 2020

View reviewed changes

addons/medical_status/functions/fnc_isInStableCondition.sqf Outdated Show resolved Hide resolved

anden3 and others added 9 commits May 5, 2020 22:52

Forgot to save the file before commiting...

ad9170f

Added Bandage Reopening Chance Modifier

57d9137

Added Wound Reopen Chance Addon Setting

6492d65

Fixed dumb error in localization setup

58d06bc

Credit!

a2ebd59

Resolved issue with Addon Settings definition & removed testing values.

3dd73e6

PR Feedback #1

4b430fc

- Removed unnecessary whitespace on LN 46 - Call global var directly at LN 87 - Updated Wound Reopen Chance localized name & description

PR Feedback #2

5473c72

- Increased reopen coefficient upper limit from 2 to 5.

Changed author credit to reflect GitHub email.

200d38f

PabstMirror modified the milestones: 3.13.3, Ongoing Jun 13, 2020

Added option to restrict PAK when patient has untreated fractures.

c617169

mharis001 reviewed Jun 8, 2021

View reviewed changes

jonpas added the status/WIP label Jul 23, 2021

dgibso29 added 6 commits January 4, 2022 19:39

Update fnc_isInStableCondition.sqf

b30de99

Merge branch 'master' into pr/7684

0f46553

Revert "Merge branch 'master' into pr/7684"

c1bec3a

This reverts commit 0f46553, reversing changes made to b30de99.

Update fnc_isInStableCondition.sqf

c02f89c

Update fnc_isInStableCondition.sqf

936125a

Update fnc_isInStableCondition.sqf

44931f6

Updated Required Wound State to PAK to current standard -- Bandaged w…

d77decf

…ounds.

Fixed conditional logic in Stitched Requirement check. MP test comple…

2f9f406

…ted successfully.

Merge pull request #5 from dgibso29/pr/7684

e6fd8b9

Hopefully finishing this PR once and for all...

PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022

dgibso29 added a commit to dgibso29/ACE3 that referenced this pull request Jul 12, 2022

Restored changed from stale PR acemod#7684

233f350

Co-Authored-By: André Vennberg <andre.vennberg@gmail.com>

dgibso29 mentioned this pull request Jul 12, 2022

Medical Treatment - Add Additional Conditions for PAK Use #8964

Closed

3 tasks

anden3 closed this Jul 19, 2022

johnb432 removed this from the Ongoing milestone Sep 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Medical - Add more conditions on when the PAK can be used (#7682) #7684

Medical - Add more conditions on when the PAK can be used (#7682) #7684

anden3 commented May 5, 2020

PabstMirror commented Jun 13, 2020

anden3 commented Jun 13, 2020

LuizBarros99 commented Jun 15, 2020

mharis001 Jun 8, 2021

mharis001 Jun 8, 2021

mharis001 Jun 8, 2021

dgibso29 commented Jun 14, 2021

dgibso29 commented Aug 16, 2021

dgibso29 commented Jan 5, 2022

dgibso29 commented Jan 5, 2022

mharis001 commented Jan 5, 2022

rautamiekka commented Jan 5, 2022 •

edited

Loading

dgibso29 commented Jan 19, 2022 •

edited

Loading

dgibso29 commented May 24, 2022

dgibso29 commented Jun 23, 2022

dgibso29 commented Jul 12, 2022

anden3 commented Jul 19, 2022



		// Require stitched wounds.
		if (EGVAR(medical_treatment,requiredWoundStatePAK) == 2 && { !(count GET_OPEN_WOUNDS(_unit) == count GET_STITCHED_WOUNDS(_unit)) }) exitWith {false};

Medical - Add more conditions on when the PAK can be used (#7682) #7684

Medical - Add more conditions on when the PAK can be used (#7682) #7684

Conversation

anden3 commented May 5, 2020

PabstMirror commented Jun 13, 2020

anden3 commented Jun 13, 2020

LuizBarros99 commented Jun 15, 2020

mharis001 Jun 8, 2021

Choose a reason for hiding this comment

mharis001 Jun 8, 2021

Choose a reason for hiding this comment

mharis001 Jun 8, 2021

Choose a reason for hiding this comment

dgibso29 commented Jun 14, 2021

dgibso29 commented Aug 16, 2021

dgibso29 commented Jan 5, 2022

dgibso29 commented Jan 5, 2022

mharis001 commented Jan 5, 2022

rautamiekka commented Jan 5, 2022 • edited Loading

dgibso29 commented Jan 19, 2022 • edited Loading

dgibso29 commented May 24, 2022

dgibso29 commented Jun 23, 2022

dgibso29 commented Jul 12, 2022

anden3 commented Jul 19, 2022

rautamiekka commented Jan 5, 2022 •

edited

Loading

dgibso29 commented Jan 19, 2022 •

edited

Loading