Dragging - Corpse carrying and dragging - continued

[johnb432]

When merged this pull request will:

• Changes related to corpse carrying from Dragging - Corpse carrying and dragging - continued #9269.
• Continuation of Medical - Add corpse carrying and dragging #7939.
• Requires 2.14 because of this: https://feedback.bistudio.com/T168091.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[PabstMirror]

encountered some weird invisibility and body duplication
https://www.youtube.com/watch?v=gvnRnQPhjf0

[johnb432]

Changelog of b32ad48:

• Added actions to dead units. I do not know of any downsides of using allDeadMen to get all dead units, so I went with that. Extended EH don't seem to trigger on dead units, that's why this was needed.
• Added some delays for clone creation and deletion, in order to get their corpses to be synced better. On my end the duplication of bodies is gone, but I haven't tested on a dedicated server.
• Corpse is removed from garbage collector, so that it can be kept. If it's deleted through other manners, the unit will just drop the clone (as opposed to before, when it kept the clone on their back) and clone will be deleted.

[LinkIsGrim]

No issues observed when testing with a small player count (8 players). Code LGTM.

We'll never get full scale testing done, banana principle it is IMO.

Stale

[LinkIsGrim]

According to @BrettMayson

and yeah the carrying is still a little too buggy
at least a third of the time they snap back after being dropped

I think we'll have to concede defeat to the engine on this one.

[johnb432]

According to @BrettMayson

and yeah the carrying is still a little too buggy
at least a third of the time they snap back after being dropped

I think we'll have to concede defeat to the engine on this one.

If it's the carrying that's causing the issue, then I'd say we drop that (pun not intended), but keep dragging - unless both are problematic. If so, then I agree and we'll need to put this PR down.

[BrettMayson]

I didn't mean the carrying is buggy while dragging is not, both have the problem

[Drofseh]

Could we add it but disabled by default,with a tooltip warning saying it's buggy?

[rautamiekka]

Could we add it but disabled by default,with a totip warning saying it's buggy?

Would be sufficient if the feature itself otherwise works, better than nothing that way.

[jonpas]

If it is 1 out of 3 times bugged as @BrettMayson put it, then it should not be in core ACE3. It can be an optional component like ace_particles though.

[Drofseh]

If it is 1 out of 3 times bugged as @BrettMayson put it, then it should not be in core ACE3. It can be an optional component like ace_particles though.

having it the optionals would be ok with me!

[BrettMayson]

It would be neat if we could just get someone to look at this on the engine side and see if it could be implemented...

When it does work, we really love it

[LinkIsGrim]

Back to ongoing this goes

[johnb432]

@BrettMayson Can you this test again? I tested this version on a dedicated server and found it worked.

[Dystopian]

I did some tests on dedicated and didn't see any bugs.

[johnb432]

I did some tests on dedicated and didn't see any bugs.

I actually found some weird behaviour, which I forgot to report here:
When JIP, it seems to act weirdly when you try to walk over bodies, as if the body was standing up or had some collision at least (when it usually doesn't). I had enhanced movement enabled, as well as many other mods, so idk how that affects that.
It's not game breaking, but it's annoying.