Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add corpse carrying and dragging #7939

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

BaerMitUmlaut
Copy link
Member

When merged this pull request will:

  • Allow carrying or dragging corpses

When starting to carry or drag a corpse, a clone without any AI is created, which you can carry or drag just fine. Once the clone is dropped, the original corpse is teleported and the clone is destroyed.

Needs MP testing.

@BaerMitUmlaut BaerMitUmlaut added the kind/enhancement Release Notes: **IMPROVED:** label Oct 4, 2020
addons/dragging/functions/fnc_dropClone.sqf Show resolved Hide resolved
addons/dragging/functions/fnc_dropClone.sqf Outdated Show resolved Hide resolved
addons/dragging/functions/fnc_carryObject.sqf Outdated Show resolved Hide resolved
BaerMitUmlaut and others added 2 commits October 5, 2020 10:35
Co-authored-by: Dystopian <sddex@ya.ru>
Co-authored-by: Dystopian <sddex@ya.ru>
@jonpas jonpas added kind/added feature and removed kind/enhancement Release Notes: **IMPROVED:** labels Oct 5, 2020
@jonpas jonpas added this to the 3.14.0 milestone Oct 5, 2020
@BaerMitUmlaut BaerMitUmlaut changed the title Corpse carrying and dragging Medical - Corpse carrying and dragging Oct 5, 2020
@BaerMitUmlaut BaerMitUmlaut changed the title Medical - Corpse carrying and dragging Medical - Add corpse carrying and dragging Oct 5, 2020
@PabstMirror
Copy link
Contributor

PabstMirror commented Oct 6, 2020

Kill and drag clone
Rifle is left behind and can access inventory on it while clone is being dragged
Drop guy and you can access the dead's inventoy from both the gun (at spot of death) and his body (and they are synced 😕 )
edit: also if you shoot "dead" clone, he screams and dies again

image

@BaerMitUmlaut
Copy link
Member Author

@PabstMirror I can only replicate the "synched duplicate inventories" when the body is still nearby. The inventory action has a maximum distance of 3.5 m according to my tests. I can only access the gun beyond that.

@serraedoardo
Copy link
Contributor

It is unclear to me whether the weapon being left behind is or not intended behavior. I think it is reasonable for the weapon to be moved alongside the corpse.

@jonpas
Copy link
Member

jonpas commented Nov 30, 2020

It should probably be moved as realistically you would have some kind of a sling on you. However, I can see the implementation problem with trying to get those weapons (they are ground weapon holders at that point).

@BaerMitUmlaut
Copy link
Member Author

Moving the weapon holder with the body could cause a bunch more issues (garbage collections might fail, getting the correct weapon holder in itself is a problem, etc), so I'd rather not do that. I don't think it's that big of a deal tbh.

@Dystopian
Copy link
Contributor

Dystopian commented May 27, 2021

Non-local body disappears right after drop sometimes. Can't repeat with local bodies. Repro:

  1. Start mission on dedicated server.
  2. Server exec p = createGroup west createUnit ["B_Soldier_F", allPlayers#0, [], 0, "FORM"]; publicVariable "p";
  3. Kill soldier, drag body, drop it. Sometimes body disappears (I have 20-50% chance). If it didn't disappear repeat steps 2-3.
  4. Watch getPosATL p: z < 0 (I have [-3, -15] range).

@BaerMitUmlaut
Copy link
Member Author

Interesting, thank you for testing. Sounds like the body falls through the map? Maybe setting the position remotely would work better?

@Dystopian
Copy link
Contributor

Interesting, thank you for testing. Sounds like the body falls through the map? Maybe setting the position remotely would work better?

I don't know. Can't work on fix yet.
Looks like bug with dropped dead body weapon I met in #6029. But it was fixed since I created that PR so I deleted workaround there.

@Dystopian
Copy link
Contributor

Doesn't work if JIP for men who are already dead when JIP. Looks like init EH doesn't fire for dead men.

@jonpas jonpas added kind/feature Release Notes: **ADDED:** and removed kind/added feature labels Oct 14, 2021
@PabstMirror PabstMirror removed this from the 3.15.1 milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:** status/needs-testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants