Added a GitHub Action that will run flake8 on submitted PRs #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very pull request. It will annotate every error it finds.
|
@cmadjar Ready for review! Ideally, once this is accepted, I can test run the action with some Python files in this repo. |
Added more errors/warnings to ignore.
This was referenced Aug 18, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
cmadjar
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new Python linter, flake8, has been added as a GitHub Action. It will run on every submitted PR and annotate all the errors that it finds. This PR addresses the issue #649.
Documentation for the GitHub Action can be found here. Essentially, this GitHub Action runs flake8 with reviewdog. Reviewdog parses the output from flake8 and uses to it annotate code in the PR.