Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 with mriscanner.py #654

Merged
merged 1 commit into from Aug 19, 2021

Conversation

vietdhoang
Copy link
Contributor

@vietdhoang vietdhoang commented Aug 17, 2021

Summary

Ran flake8 and corrected some errors that were caught. In some of the Python files, I decided to ignore some errors (these errors are not on the list in .github/workflows/flake8_python_linter.yml) due to unique formatting that helped make the code more readable. Once #651 has been merged, you will be able to see these errors here on GitHub.

…E272,E221,E251,E241,E202,E203 --max-line-length 120 mriscanner.py
@vietdhoang vietdhoang marked this pull request as ready for review August 18, 2021 23:03
Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny that this did not report any errors when running the script.

@cmadjar cmadjar merged commit b92a815 into aces:main Aug 19, 2021
@cmadjar cmadjar modified the milestone: 24.0.0 Sep 10, 2021
@cmadjar cmadjar added this to the 24.0.0 milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants