Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install make, npm to LORIS 21.0 installation documentation. #5250

Closed
ycAbout opened this issue Sep 26, 2019 · 6 comments
Closed

Add install make, npm to LORIS 21.0 installation documentation. #5250

ycAbout opened this issue Sep 26, 2019 · 6 comments
Assignees
Labels
Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)

Comments

@ycAbout
Copy link
Contributor

ycAbout commented Sep 26, 2019

Installing Loris in Depth:
Running the Install Script section
step 9: Run make (for production instances) or make dev (for development sandboxes)
Problems:

  1. Run make requires sudo apt install make first
  2. Run make requires `sudo apt install npm' first
  3. make command need to be run under loris instead of under loris/tools
@ycAbout ycAbout added the Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) label Sep 26, 2019
@christinerogers christinerogers self-assigned this Sep 26, 2019
@christinerogers
Copy link
Contributor

christinerogers commented Sep 26, 2019

Thanks @coreyAbout - 2 clarification questions:

cc @kongtiaowang

To do:

@ycAbout
Copy link
Contributor Author

ycAbout commented Sep 26, 2019

@christinerogers
Ubuntu16
I think install most of, if not any, software through apt would need sudo. If I'm wrong please correct me.

christinerogers added a commit to kongtiaowang/Loris that referenced this issue Sep 26, 2019
* Corey's ticket aces#5250 points out that `make` and `npm` should be installed initially. 
*Revert this commit* if disagreement ensues.
christinerogers added a commit to kongtiaowang/Loris that referenced this issue Sep 26, 2019
corey's issue aces#5250 points out that make and npm installation should be specified 
*Revert this commit* (and the previous one) if disagreement ensues
@johnsaigle
Copy link
Contributor

johnsaigle commented Sep 30, 2019

Right now we don't go "in depth" into how to get the LORIS system dependencies installed, including PHP, Apache, MariaDB/MySQL, Composer, and npm. We also don't describe how to install apt package such as zip, make, etc.

The process of getting an environment ready to run software is referred to as "bootstrapping" and there are many approach to this, such as containerization (e.g. Docker, Vagrant), package managers (e.g. a sudo apt install loris Debian package, etc.

We don't really have any bootstrapping support or documentation at this time, either for development installs or full production installs.

This is a long-standing issue. See #4365 and #3981.

To respond to the above points:

  • sudo should not be required for anything in the install.sh script.
  • apt install ... will always require sudo. I believe the same is true for e.g. CentOS with yum but I don't have experience with those systems.

@ycAbout
Copy link
Contributor Author

ycAbout commented Oct 2, 2019

@johnsaigle Thanks for the comment. Right now we DO have guidelines on how to get LORIS system dependencies installed. Check it out here: https://github.com/aces/Loris/wiki/Installing-Loris-in-Depth#getting-prerequisites
All those are how to install dependencies and are well documented, except for the make and npm.
Anyway, you have a nice idea to have bootstraps packed up there.

@johnsaigle
Copy link
Contributor

You're right, there is that Wiki page. It's incomplete though, and out of date as you've noted.

@johnsaigle
Copy link
Contributor

This should now be clarified by the new install documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs)
Projects
None yet
Development

No branches or pull requests

3 participants