Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.0] [media] Form not resetting after upload #5363

Closed
leighevans opened this issue Oct 23, 2019 · 8 comments
Closed

[21.0] [media] Form not resetting after upload #5363

leighevans opened this issue Oct 23, 2019 · 8 comments
Assignees
@HenriRabalais
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned UI PR or issue introducing/requiring improvements to the LORIS User Interface

Comments

@leighevans
Copy link

leighevans commented Oct 23, 2019 •
edited by HenriRabalais

After uploading a file, the fields are reset and blank, but the Site options are still constrained for the previous upload. In theory this issue is resolved by simply entering the PSCID, which updates the Site list to the proper sites, but just an FYI that if you don't follow the data input in order, this is what happens.

Screenshot shows the site dropdown with options that pertain to the previous upload, rather than displaying all sites for a new upload.

@HenriRabalais EDIT: The same behaviour that occurs for sites also occurs for visit labels and instruments.

Screen Shot 2019-10-23 at 11 46 18 AM
@johnsaigle
Copy link
Contributor

johnsaigle commented Oct 23, 2019 •
edited

Duplicate of #5055

Related to #5055

@johnsaigle johnsaigle marked this as a duplicate of #5055 Oct 23, 2019
@jesscall
Copy link
Contributor

jesscall commented Oct 23, 2019 •
edited

@johnsaigle I believe #5055 has to do with the Browse page not updating. This issue refers to the upload form's options for site, visit and instrument not resetting -- They remain filtered based on the session data from the previous upload's PSCID

@johnsaigle
Copy link
Contributor

Got it, thanks for clarifying.

@johnsaigle johnsaigle marked this as not a duplicate of #5055 Oct 23, 2019
@johnsaigle johnsaigle added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Oct 30, 2019
@cmadjar cmadjar assigned HenriRabalais and unassigned jesscall Nov 1, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@HenriRabalais We assigned you the media module bug fixes for Monday. While you are at it, maybe you can fix this one too? Thanks!

@driusan driusan added the Critical to release PR or issue is key for the release to which it has been assigned label Nov 5, 2019
@HenriRabalais
Copy link
Collaborator

@cmadjar sounds good! should be an easy fix!

@HenriRabalais
Copy link
Collaborator

After looking into this further, there is the same issue for visit label and instruments, so I might as well tackle all the similar issues with this one PR.

@HenriRabalais HenriRabalais mentioned this issue Nov 7, 2019
Merged
@HenriRabalais
Copy link
Collaborator

PR Sent #5577

driusan pushed a commit that referenced this issue Nov 18, 2019
@HenriRabalais @driusan
[Media] Remove site and do not allow selection of fields unless relev…
d92c87b 
…ant (#5577)

Remove the site option (which was not properly saved) from the media module since it is derived from the session, and do not allow selection of instrument unless a PSCID is selected.

Resolves #5363.
@driusan
Copy link
Collaborator

driusan commented Nov 18, 2019

5577 is merged

@driusan driusan closed this as completed Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenriRabalais HenriRabalais

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Critical to release PR or issue is key for the release to which it has been assigned UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@driusan @cmadjar @johnsaigle @HenriRabalais @leighevans @jesscall