Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new_profile] If user assigned to 1 site, unhide site field and auto-populate default site #5380

Closed
zaliqarosli opened this issue Oct 24, 2019 · 11 comments · Fixed by #6156
Closed

[new_profile] If user assigned to 1 site, unhide site field and auto-populate default site #5380

zaliqarosli opened this issue Oct 24, 2019 · 11 comments · Fixed by #6156
Assignees
@zaliqarosli
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation UI PR or issue introducing/requiring improvements to the LORIS User Interface

Comments

@zaliqarosli
Copy link
Contributor

zaliqarosli commented Oct 24, 2019 •
edited

currently, if the user is assigned to only 1 site, new profile will not show the site field. on the php side, the value of site is assigned by default the user's first and only site.

ideally, the site field will always show and just auto-populate the one and only available site so users don't have to select it themselves.
@driusan
Copy link
Collaborator

driusan commented Oct 25, 2019

Why?

@zaliqarosli
Copy link
Contributor Author

@driusan because it looks like there's a bug when the site field is missing!

@johnsaigle johnsaigle added Cleanup PR or issue introducing/requiring at least one clean-up operation UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Oct 28, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@ridz1208 could you look into this one please? Thank you!

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 1, 2019

@cmadjar this is by design right now, it's how Mouna intended it to be. we would have to decide if thats the way people prefer it before changing the functionality...

I agree it looks like a bug but it isn't one unless we all agree on it

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@ridz1208 sounds good. Can you add this to the agenda of the LORIS meeting?

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 4, 2019

@cmadjar done

@ridz1208 ridz1208 added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 4, 2019
@ridz1208 ridz1208 removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Nov 19, 2019
@ridz1208 ridz1208 removed their assignment Nov 29, 2019
@ridz1208 ridz1208 mentioned this issue Dec 16, 2019
Closed
@stale
Copy link

stale bot commented Jan 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Jan 28, 2020
@zaliqarosli
Copy link
Contributor Author

@ridz1208 do you remember the decision made post discussion on this? i can go ahead and make the changes if it is good to be implemented

@stale
Copy link

stale bot commented Jan 28, 2020

The Stale label is being removed automatically because some activity has occurred or because the developers have decided that this pull request is important and should not continue to be overlooked.

@stale stale bot removed the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Jan 28, 2020
@ridz1208
Copy link
Collaborator

ridz1208 commented Jan 28, 2020 •
edited

@zaliqarosli the decision was to go ahead with this !

you can do the same for project as well

Is there any way to do this automatically for ANY dropdown that only has one option ? (maybe we can discuss that)

@zaliqarosli zaliqarosli self-assigned this Jan 28, 2020
@ridz1208 ridz1208 mentioned this issue Jan 28, 2020
Merged
@zaliqarosli zaliqarosli mentioned this issue Mar 11, 2020
Merged
@zaliqarosli
Copy link
Contributor Author

zaliqarosli commented Mar 11, 2020 •
edited

Is there any way to do this automatically for ANY dropdown that only has one option ? (maybe we can discuss that)

@ridz1208 this PR does what you mentioned above #6156

driusan pushed a commit that referenced this issue Aug 19, 2020
@zaliqarosli
[new_profile] Auto-select only site option (#6156)
34d1d5a 
Resolves #5380
zaliqarosli added a commit to zaliqarosli/Loris that referenced this issue Sep 3, 2020
@zaliqarosli
[new_profile] Auto-select only site option (aces#6156)
e4bfeca 
Resolves aces#5380
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this issue Jun 29, 2021
@zaliqarosli @AlexandraLivadas
[new_profile] Auto-select only site option (aces#6156)
8eddadd 
Resolves aces#5380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaliqarosli zaliqarosli

Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new_profile] Auto-select only site option zaliqarosli/Loris
5 participants
@driusan @cmadjar @johnsaigle @ridz1208 @zaliqarosli