Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[user_accounts] Can set password and email to be the same #5416

Closed
leighevans opened this issue Oct 30, 2019 · 5 comments
Closed

[user_accounts] Can set password and email to be the same #5416

leighevans opened this issue Oct 30, 2019 · 5 comments
Assignees
@johnsaigle
Labels
Critical to release PR or issue is key for the release to which it has been assigned

Comments

@leighevans
Copy link

One of the password rules "The password and the email address must not be the same" isn't enforced; can set email as password with no issue
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@nicolasbrossard we assigned you the user accounts bugs to fix for Monday. If you could look into them that would be awesome. Thanks!

@driusan driusan added the Critical to release PR or issue is key for the release to which it has been assigned label Nov 5, 2019
@johnsaigle
Copy link
Contributor

@nicolasbrossard I can take this one if you want. I recently rewrote a lot of this code.

@nicolasbrossard
Copy link
Contributor

@johnsaigle Accepted! Thanks John!

@driusan driusan assigned johnsaigle and unassigned nicolasbrossard Nov 5, 2019
@johnsaigle johnsaigle mentioned this issue Nov 5, 2019
Merged
driusan pushed a commit that referenced this issue Nov 5, 2019
@johnsaigle @driusan
[User Accounts] Fix password bugs: "confirm password" must match; pas…
1da1660 
…sword cannot be email (#5426)

Password and Confirm Password on the front-end don't need to match on major. This check was removed by mistake during Password refactoring.

Fixes #5416, #5417
@driusan
Copy link
Collaborator

driusan commented Nov 5, 2019

Fixed by above PR

@driusan driusan closed this as completed Nov 5, 2019
@johnsaigle
Copy link
Contributor

This apparently wasn't fixed. I think I missed committing a file. It's now addressed in #5538

@johnsaigle johnsaigle reopened this Nov 11, 2019
@johnsaigle johnsaigle mentioned this issue Nov 11, 2019
Merged
driusan pushed a commit that referenced this issue Nov 14, 2019
@johnsaigle @driusan
[User Accounts] Add integration tests for password change logic (#5538)
2625aad 
Integration tests now verify:

    "Password" and "Confirm password" must match
    Password must not match email
    Password must be changed (i.e. submitting the same password as you had before gives an error)

This is done for both "My Preferences" and "Edit User"

Resolves #5416
@driusan driusan closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnsaigle johnsaigle

Labels
Critical to release PR or issue is key for the release to which it has been assigned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@driusan @cmadjar @johnsaigle @nicolasbrossard @leighevans