Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRI Violations] "Type of problem" data missing from Raisinbread #5420

Closed
johnsaigle opened this issue Oct 30, 2019 · 3 comments
Closed

[MRI Violations] "Type of problem" data missing from Raisinbread #5420

johnsaigle opened this issue Oct 30, 2019 · 3 comments
Assignees
@cmadjar
Labels
RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Comments

@johnsaigle
Copy link
Contributor

Test Plan

Filter for scans that violate MRI Protocol violation (For each type of Problem : Could not identify scan type, Visit Label does not exist,
Protocol Violation, CandID and PSCID do not match and CandID does not exist).

The only types that exists in the dataset are:

  • Could not identify scan type
  • Protocol Violation
@johnsaigle johnsaigle added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset 22.0.0 TESTING labels Oct 30, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Oct 30, 2019

right. I guess I'll have to insert some failed Visit label and CandID/PSCID do not match. Assigning to me for now.

@cmadjar cmadjar self-assigned this Oct 30, 2019
@cmadjar cmadjar mentioned this issue Nov 13, 2019
Merged
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 13, 2019

@johnsaigle It took forever to do it but this is finally done! (meaning the PR #5639 was sent)

driusan pushed a commit that referenced this issue Nov 14, 2019
@cmadjar @driusan
updated RB with other types of MRI violations by running the insertio…
52f3257 
…n pipeline on sessions that would fail the candidate validation (#5639)

This updates the RB datasets with additional types of MRI violations related to failure to validate the candidate information stored in the PatientName. New types of violations in the RB datasets are now:

- Visit label Visit1 does not exist in Visit_Windows
- Visit label Visit2 does not exist in Visit_Windows
- CandID does not exist
-PSCID and CandID of the image mismatch

Fixes #5420
@driusan
Copy link
Collaborator

driusan commented Nov 14, 2019

PR merged

@driusan driusan closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmadjar cmadjar

Labels
RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driusan @cmadjar @johnsaigle