Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Candidate Parameters][major] Module broken? Form loads then disappears #5434

Closed
johnsaigle opened this issue Oct 30, 2019 · 3 comments
Closed

[Candidate Parameters][major] Module broken? Form loads then disappears #5434

johnsaigle opened this issue Oct 30, 2019 · 3 comments
Assignees
@jesscall
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface

Comments

@johnsaigle
Copy link
Contributor

johnsaigle commented Oct 30, 2019 •
edited

(On aces/major, with Raisinbread data, definitely recompiled JavaScript, Chrome and Firefox)

Candidate parameters seems to be broken.

Clicking on any candidate the form to load for a second and then it gets deleted, leaving a blank page.
@johnsaigle johnsaigle added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Oct 30, 2019
@johnsaigle johnsaigle changed the title [Candidate Parameters] Module broken? Form loads then disappears [Candidate Parameters][major] Module broken? Form loads then disappears Oct 30, 2019
@dyt811
Copy link

dyt811 commented Oct 31, 2019

Reproduced in 22.0 testing.
Steps:

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@jesscall can you look into this on Monday please? Thanks!

@jesscall jesscall mentioned this issue Nov 4, 2019
Merged
driusan pushed a commit that referenced this issue Nov 4, 2019
@jesscall @driusan
[candidate_parameters][bugfix] getData returning candID object was br…
e9cf85e 
…eaking react (#5518)

Fix bug where forms were loading and then disappearing quickly afterwards on the candidate_parameters page.

When returning the CandID object in the getData.php file, incorrect data was returned because React was expecting a string and cannot render the object that was passed.

Resolves #5434
@driusan
Copy link
Collaborator

driusan commented Nov 4, 2019

Fixed by above

@driusan driusan closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesscall jesscall

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@driusan @cmadjar @johnsaigle @dyt811 @jesscall