Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document_repository] user a edits while user b deletes #5456

Closed
3design opened this issue Oct 31, 2019 · 3 comments
Closed

[document_repository] user a edits while user b deletes #5456

3design opened this issue Oct 31, 2019 · 3 comments
Assignees
Labels
Critical to release PR or issue is key for the release to which it has been assigned Needs Documentation PR awaiting proper documentation of the changes

Comments

@3design
Copy link

3design commented Oct 31, 2019

  1. User A edits a file. User B tries to delete the same file in the meantime. Check that he can't. [Manual Testing]

expected results:
when one user edits a file, another user cannot delete the file

actual results:
while user a is in the edit screen, user b can delete the file as normal

@johnsaigle
Copy link
Contributor

I think the documentation needs to be updated for this one. There aren't (maybe never have been) user permissions on the document repository to restrict a user from deleting another user's file.

@zaliqarosli
Copy link
Contributor

^ yes i agree

@johnsaigle johnsaigle added the Needs Documentation PR awaiting proper documentation of the changes label Nov 4, 2019
@driusan driusan added the Critical to release PR or issue is key for the release to which it has been assigned label Nov 5, 2019
driusan pushed a commit that referenced this issue Nov 5, 2019
Remove test for functionality that was never implemented and clarify other points.

Fixes #5456.
@driusan
Copy link
Collaborator

driusan commented Nov 5, 2019

Documentation updated by above.

@driusan driusan closed this as completed Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical to release PR or issue is key for the release to which it has been assigned Needs Documentation PR awaiting proper documentation of the changes
Projects
None yet
Development

No branches or pull requests

5 participants