Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Media] Language option in 'Edit' page #5459

Closed
SantiagoTG opened this issue Oct 31, 2019 · 4 comments
Closed

[Media] Language option in 'Edit' page #5459

SantiagoTG opened this issue Oct 31, 2019 · 4 comments
Assignees
@HenriRabalais
Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Feature PR or issue introducing/requiring at least one new feature

Comments

@SantiagoTG
Copy link
Contributor

When trying to edit data using the Edit button under the "Edit Metadata" tab, there is no language option, and so language cannot be edited.
@SantiagoTG SantiagoTG added Feature PR or issue introducing/requiring at least one new feature Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS 22.0.0 TESTING labels Oct 31, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@HenriRabalais Can you look into this?

@HenriRabalais
Copy link
Collaborator

@cmadjar There seems to be other issues preventing me from resolving this - the media edit form won't load at the moment. It seems like there's issues with ID value being passed to the edit form. I will look at resolving that issue first, and then tackling this one.

@HenriRabalais HenriRabalais mentioned this issue Nov 8, 2019
Merged
@HenriRabalais
Copy link
Collaborator

PR Sent: #5585

driusan pushed a commit that referenced this issue Nov 11, 2019
@HenriRabalais @driusan
[Media] Added Project to Columns; Added Language to Edit File Form (#…
8204b53 
…5585)

This fixes 2 issues:

#5581: The MediaFileProvisioner was adding the project column and filter, but the edit window had not been updated resulting in it not loading.

#5459: There was no field for 'Language' in the edit media form, and therefore there was no way to edit language. Language has now been added as a field and is editable.
@HenriRabalais
Copy link
Collaborator

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HenriRabalais HenriRabalais

Labels
Beginner Friendly PR or Issue appears to be easy for someone to use to familiarize themselves with LORIS Feature PR or issue introducing/requiring at least one new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cmadjar @HenriRabalais @maltheism @SantiagoTG