Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data_release] there is no access point for regular user except manually type in url #5496

Closed
ycAbout opened this issue Nov 1, 2019 · 5 comments
Assignees

Comments

@ycAbout
Copy link
Contributor

ycAbout commented Nov 1, 2019

There are two permissions related to this module under user accounts:
Data Release: Grant other users view-file permissions
Data Release: Upload file
Without grant at lease one of these permissions to a regular user, there is no access point for the user to visit this module except manually type in url: https://test-loris-dev.loris.ca/data_release
Not sure how things work in real use case, but if loris want regular users who do not have these two permissions to visit the data_release module, the access point need to be added.

@cmadjar
Copy link
Collaborator

cmadjar commented Nov 1, 2019

@Jkat can you please look into this issue? Thanks!

@ridz1208
Copy link
Collaborator

ridz1208 commented Nov 6, 2019

@Jkat i made a PR for it

@coreyAbout you can test my PR see if it fixes the issue

@ycAbout
Copy link
Contributor Author

ycAbout commented Nov 6, 2019

@ridz1208 Hi Rida, For sure, I can do it next week. I have used up all my time for LORIS team for this week.

driusan pushed a commit that referenced this issue Nov 6, 2019
This adds a new permission to the database to allow users view/download access to the data release module. the other 2 permissions that already exist give the user slightly more power, this one is the most basic access.

Addresses #5496
@driusan driusan closed this as completed Nov 6, 2019
@ycAbout
Copy link
Contributor Author

ycAbout commented Nov 12, 2019

Hello, I am reopening this issue, because when I was testing on https://test-loris-dev.loris.ca/,
In user permission page, I cannot find any new added permission for this module in the permission list. Only the previous two exist.

@ycAbout ycAbout reopened this Nov 12, 2019
@ycAbout
Copy link
Contributor Author

ycAbout commented Nov 12, 2019

Close issue as #5612 fixed.

@ycAbout ycAbout closed this as completed Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants