Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next_stage/battery] When instruments are using instrument permissions they can not be populated at the next_stage step #7435

Closed
ridz1208 opened this issue Apr 27, 2021 · 4 comments
Assignees
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@ridz1208
Copy link
Collaborator

Describe the bug
LORIS allows instruments to use instrument permissions where access to specific instruments can be checked based on a project-specific permission code. This works well to restrict access to a specific instrument in a timepoint but maintain access to the rest of the instruments in the same timepoint

Issue: If a user who does not have the instrument permission tries to "start next stage" the battery will still be populated but a 500 error will be displayed to the user. After a refresh the intrument_list module will be populated regardless...

What did you expect to happen?
The battery should be populated without error, it's only access to the instrument that should be restricted, not it's creation

@ridz1208 ridz1208 added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Apr 27, 2021
@ridz1208
Copy link
Collaborator Author

might be fixed by #8290

@ridz1208
Copy link
Collaborator Author

@miladheshmati to test after above PR is merged

@miladheshmati
Copy link
Contributor

@ridz1208, tested, no issue was found

@driusan
Copy link
Collaborator

driusan commented Jun 7, 2023

Fixed according to above comment.

@driusan driusan closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

3 participants