[Instrument] Remove exception from NDB_BVL_Instrument::factory #8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Cleanup
driusan
force-pushed
the
InstrumentSeparateAccessCheck
branch
from
be27b1f
to
783e387
Compare
This was referenced Dec 20, 2022
driusan
added
the
Blocking
driusan
force-pushed
the
InstrumentSeparateAccessCheck
branch
from
783e387
to
473bfea
Compare
ridz1208
reviewed
Feb 21, 2023
| @@ -252,6 +252,11 @@ class Unresolved extends Endpoint implements ETagCalculator | |||
| '', | |||
| true | |||
| ); | |||
| if ($instrument->_hasAccess($user) == false) { | |||
| return new \LORIS\Http\Response\JSON\NotFound( | |||
This removes the exception from NDB_BVL_Instrument::factory(), so that it's possible to call hasAccess on an instrument. Currently the hasAccess or Factory call mix concerns, making it difficult for a module to check if a user has access to an instrument.
driusan
force-pushed
the
InstrumentSeparateAccessCheck
branch
from
473bfea
to
a4784be
Compare
ridz1208
reviewed
Feb 21, 2023
ridz1208
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the exception from NDB_BVL_Instrument::factory(), so that it's possible to call hasAccess on an instrument. Currently the hasAccess or Factory call mix concerns, making it difficult for a module to check if a user has access to an instrument.