Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to create a candidate born on 0000-00-00 #8144

Closed
nicolasbrossard opened this issue Jul 19, 2022 · 2 comments
Closed

Able to create a candidate born on 0000-00-00 #8144

nicolasbrossard opened this issue Jul 19, 2022 · 2 comments
Assignees
@regisoc
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@nicolasbrossard
Copy link
Contributor

Using Safari, an IBIS user was able to create a candidate born on 0000-00-00. Since Safari does not offer calendar widgets to enter dates, she had to rely on a text field to enter the DoB and she used the wrong date separator ('/' instead of '-'). The date was saved as '0000-00-00' afterwards since its format was invalid. For reference, IBIS is on LORIS 23 and uses MySQL 5.1.73.
@nicolasbrossard nicolasbrossard added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Jul 19, 2022
@nicolasbrossard nicolasbrossard self-assigned this Jul 19, 2022
regisoc added a commit that referenced this issue Sep 30, 2022
@regisoc
Fix for #8127 and #8144.
83ab6bd 
Several behaviors related to date parsing. When using `/new_profile` or
`/api/v0.0.3/candidates` to add candidates, date parsing allowed date
such as 0000-00-00 or with possible multiple separators when only
months were provided (e.g. 'yyyy/mm'). Only one format was really used
(i.e. 'yyyy-mm-dd' for sql compatibility).

This fix checks multiple date formats and 3 separators (i.e. '-', '/',
and '.'). E.g. some valid date formats: 'yyyy-mm', 'dd/mm/yyyy',
'yyyy-mm-dd'.
@regisoc regisoc mentioned this issue Sep 30, 2022
Closed
@nicolasbrossard
Copy link
Contributor Author

Bug still there as of 2022-12-12

@laemtl laemtl assigned regisoc and unassigned nicolasbrossard Dec 13, 2022
@regisoc regisoc mentioned this issue Dec 18, 2022
Closed
@ridz1208
Copy link
Collaborator

fixed in latest bugfix 24.1 #8279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@regisoc regisoc

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] fix invalid date error aces/Loris
3 participants
@nicolasbrossard @ridz1208 @regisoc