[Image Uploader] fix naming convention check

[gluneau]

Previous name was too strict.

• Could not upload a second scan set for same visit.
• Could not include RES or HOS to separate scanners.

[alisterdev]

Suggestion:

/**
   * Checks if the inputted file name is valid
   *
   * @param {string} requiredFileName - Required file name
   * @param {string} fileName - Provided file name
   * @return {boolean} - true if file names match and false otherwise
   */
  isValidFileName: function(requiredFileName, fileName) {
    if (fileName === null || requiredFileName === null) {
      return false;
    }

    return (fileName.indexOf(requiredFileName) > -1);
  }

Note: snippet is in JS, but can be adapted to PHP easily using strpos()

Note 2: If you want requiredFileName to always be the beginning of the fileName, use:
return (fileName.indexOf(requiredFileName) === 0);

[driusan]

alternatively you could use a regular expression. Something likelike:

if preg_match(/^{$pscid}{$candid}{$visit_label}.*(zip|tgz|tar.gz/) {
}

[codecov-io]

Current coverage is 13.71% (diff: 0.00%)

Merging #2100 into 16.1-dev will increase coverage by 0.27%

@@           16.1-dev      #2100   diff @@
==========================================
  Files           118        118          
  Lines         19923      20065   +142   
  Methods        1116       1116          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2678       2752    +74   
- Misses        17245      17313    +68   
  Partials          0          0          

Powered by Codecov. Last update 10b611b...b8add23

[christinerogers]

Update documentation to tell people what filenames the imaging uploader will accept:

• Wiki: Imaging Database Setup page
• help text for the module