-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imaging Browser: Add Caveat flag for session table: Redmine 6039 #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MounaSafiHarab
commented
Aug 18, 2016
•
edited
edited
- Added Caveat button (True/False; default is False) in imaging browser
- Caveat column in session table
MounaSafiHarab
added
Add to Release Notes
PR change should be highlighted in Release notes (important security, features and bugfixes)
Feature
PR or issue introducing/requiring at least one new feature
Caveat for Existing Projects
PR contains changes that might impact the code or accepted practices of current active projects
SQL
PR contains SQL modifications such as schema changes and new SQL scripts
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
labels
Aug 18, 2016
Current coverage is 13.73% (diff: 0.00%)@@ 17.0-dev #2135 diff @@
==========================================
Files 118 118
Lines 20096 20084 -12
Methods 1120 1120
Messages 0 0
Branches 0 0
==========================================
+ Hits 2744 2759 +15
+ Misses 17352 17325 -27
Partials 0 0
|
MounaSafiHarab
removed
the
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
label
Aug 19, 2016
gluneau
added
PassedCodeReview
Passed Manual Tests
PR has undergone proper testing by at least one peer
labels
Aug 25, 2016
@@ -1040,6 +1040,7 @@ CREATE TABLE `session` ( | |||
`MRIQCPending` enum('Y','N') NOT NULL default 'N', | |||
`MRIQCFirstChangeTime` datetime default NULL, | |||
`MRIQCLastChangeTime` datetime default NULL, | |||
`Caveat` enum('true','false') NOT NULL default 'false', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this Caveat flag for the whole session, or just for the imaging?
It's on the session table, so it's a little confusing that it's called "session.Caveat" but referred to as "mricaveat" in the template.
MounaSafiHarab
removed
PassedCodeReview
Passed Manual Tests
PR has undergone proper testing by at least one peer
labels
Sep 1, 2016
gluneau
added
PassedCodeReview
Passed Manual Tests
PR has undergone proper testing by at least one peer
labels
Sep 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add to Release Notes
PR change should be highlighted in Release notes (important security, features and bugfixes)
Caveat for Existing Projects
PR contains changes that might impact the code or accepted practices of current active projects
Feature
PR or issue introducing/requiring at least one new feature
Passed Manual Tests
PR has undergone proper testing by at least one peer
SQL
PR contains SQL modifications such as schema changes and new SQL scripts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.