[user_accounts] Registering a user as an examiner #2190
Conversation
ridz1208
added
Feature
Current coverage is 13.68% (diff: 5.75%)@@ 17.0-dev #2190 diff @@
==========================================
Files 121 121
Lines 20241 20380 +139
Methods 1132 1133 +1
Messages 0 0
Branches 0 0
==========================================
+ Hits 2787 2788 +1
- Misses 17454 17592 +138
Partials 0 0
|
| @@ -143,6 +144,28 @@ | |||
| 'Email' => $from, | |||
| 'CenterID' => $site, | |||
| ); | |||
| /* | |||
| foreach($_REQUEST as $k=>$v) { | |||
| error_log($k." --> ".$v); | |||
There was a problem hiding this comment.
@ridz1208
user_accounts/test/user_accountsTest.php:184
$this->_verifyUserModification(
'user_accounts',
'UnitTester',
'First_name',
// 'NewFirst' => 'Unit',
'Unit'
);
try it
|
@taracampbell try entire procedure as new user requesting account plz @gluneau try messing around with front end while verifying database changes in effect and code review please |
ridz1208
added
Bug
kongtiaowang
added
the
Passed Manual Tests
…m the user accounts edit user menu
ridz1208
force-pushed
the
2016_09_14_user_accounts_add_examiner
branch
from
6963c0d
to
00e98f5
Compare
| ); | ||
| } | ||
| $groupB[] = $this->createLabel( | ||
| " <b>Radiologist: </b>" |
There was a problem hiding this comment.
Not sur about the html in php. This should be in the template.
There was a problem hiding this comment.
HTML in PHP is done throughout this module (see 670-678) and maintained here for consistency of the template form
- {$form.examiner_sites.label} - -| ) | ||
| ); | ||
| $groupB[] = $this->createLabel( | ||
| " <b>Pending Approval: </b>" |
There was a problem hiding this comment.
Not sur about the html in php. This should be in the template.
|
Test cases to be added in the test plan if not in the Integration tests. |
|
@ridz1208, I just tested. After requesting an account, that user gets added to the examiner table successfully. However, there appears to be a problem with adding them to the user table (i.e. they do not get added, the name does not show up in user accounts). I get errors like this in my error log: Perhaps this is an unrelated issue though. |
|
@taracampbell that seems to be a ccna specific issue try adding a user called lorisadmin to your users table. See if that solves it https://github.com/aces/CCNA/pull/737 |
| @@ -909,6 +909,7 @@ class NDB_BVL_Instrument extends NDB_Page | |||
| WHERE testID =:tid | |||
| AND pass =:cert_id | |||
| AND centerID =:cid | |||
| AND examiners.active='Y' | |||
There was a problem hiding this comment.
What happens here to existing data if there's data already saved and the examiner active flag changes?
|
@ridz1208 I already have the lorisadmin user, so I don't think that's problem. I will try to figure out what's going on, but if someone has already tested this and it is working, I don't see why my additional validation is required in order to merge this. |
|
Basic testing done - everything seems to be working. |
add support for registering a user as an examiner from the user accounts edit user menu