Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MySQL 5.7] - Basic compliance #2222

Merged
merged 2 commits into from
Sep 29, 2016
Merged

[MySQL 5.7] - Basic compliance #2222

merged 2 commits into from
Sep 29, 2016

Conversation

xlecours
Copy link
Contributor

@xlecours xlecours commented Sep 29, 2016 •
edited

This basically use our intergration tests to check if all pages load when LORIS is installed on a MySQL 5.7 database.

  • Change of default values in the tarchive table.
  • Making setUp() function in integration tests insert valid records.
  • Changing date input format in new_profileTest.php
  • Removing reference assignment in NDB_Form_user_accounts.class.inc
  • Lowering the default timeout of safeFindElement from 15 seconds to 1 seconds

@xlecours xlecours added Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects SQL PR contains SQL modifications such as schema changes and new SQL scripts labels Sep 29, 2016
@xlecours xlecours added this to the 17.0 milestone Sep 29, 2016
@xlecours xlecours mentioned this pull request Sep 29, 2016
Closed
1 task
@codecov-io
Copy link

Current coverage is 13.80% (diff: 0.00%)

Merging #2222 into 17.0-dev will decrease coverage by <.01%

@@           17.0-dev      #2222   diff @@
==========================================
  Files           121        121          
  Lines         20191      20191          
  Methods        1133       1133          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2788       2787     -1   
- Misses        17403      17404     +1   
  Partials          0          0

Powered by Codecov. Last update f966594...1935e31

driusan
driusan approved these changes Sep 29, 2016
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little surprised some of these worked with other versions of MySQL..

@driusan driusan merged commit 4755174 into aces:17.0-dev Sep 29, 2016
@xlecours xlecours mentioned this pull request Oct 17, 2016
Merged
driusan pushed a commit that referenced this pull request Oct 17, 2016
@xlecours @driusan
[Schema] Defaut date values #2291
8fd3e9e 
This is a missing patch for #2222
@xlecours xlecours deleted the MySQL5-7_compliance branch November 1, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan driusan approved these changes

Assignees
No one assigned
Labels
Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects SQL PR contains SQL modifications such as schema changes and new SQL scripts
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xlecours @codecov-io @driusan