Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Genomic Browser] Uploader progress bar #2231

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

xlecours
Copy link
Contributor

This is almost identical to #2069 but based on 17.0-dev branch.
It is a contribution of @manubati that I have rebased

The log that were sent to the console are now shown in a progress bar.

@xlecours xlecours added the UI PR or issue introducing/requiring improvements to the LORIS User Interface label Sep 29, 2016
@xlecours xlecours added this to the 17.0 milestone Sep 29, 2016
@xlecours xlecours changed the title Adding Benjamin`s summer contributions [Genomic Browser] Uploader progress bar Sep 29, 2016
@codecov-io
Copy link

Current coverage is 13.91% (diff: 100%)

Merging #2231 into 17.0-dev will increase coverage by 0.11%

@@           17.0-dev      #2231   diff @@
==========================================
  Files           121        123     +2   
  Lines         20203      20297    +94   
  Methods        1133       1144    +11   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2788       2825    +37   
- Misses        17415      17472    +57   
  Partials          0          0          

Powered by Codecov. Last update 4755174...f78d727

@alisterdev alisterdev added PassedCodeReview Passed Manual Tests PR has undergone proper testing by at least one peer labels Oct 4, 2016
Copy link
Contributor

@alisterdev alisterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sweet and works great!

@alisterdev alisterdev self-assigned this Oct 4, 2016
@driusan driusan added the Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) label Oct 6, 2016
@driusan driusan merged commit f87dbed into aces:17.0-dev Oct 6, 2016
@xlecours xlecours deleted the genomic_uploader_progressbar branch November 1, 2016 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Passed Manual Tests PR has undergone proper testing by at least one peer UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants