Fix for Remine ticket #10927: the server processes files are deleted only if the pipeline's exit code is 0. #2252
Conversation
…only if the pipeline's exit code is 0.
nicolasbrossard
added
the
Feature
| */ | ||
| public function deleteProcessFiles() | ||
| { | ||
| return !is_null($exitCode) && is_numeric($exitCode) && $exitCode == 0; |
There was a problem hiding this comment.
$exitCode doesn't seem to be defined in any scope that would mean the variable could be used here like this. It's neither an argument nor local variable..
There was a problem hiding this comment.
@nicolasbrossard @driusan
shouldn't the change have been made in:
https://github.com/aces/Loris/blob/master/modules/server_processes_manager/php/AbstractServerProcess.class.inc#L521
This is the line that I used to alternate between True/False depending on whether I wanted to keep those files or not...
There was a problem hiding this comment.
Deleting the process files only if the exit code is 0 is something that is specific to the MRI upload processes. I think the default behaviour (to delete all files all the time, which is defined in AbstractServerProcess) should remain as is and should only be overridden in MriUploadServerProcess.
alisterdev
added
the
Needs Work
alisterdev
removed
the
Needs Work
MounaSafiHarab
added
the
Passed Manual Tests
driusan
added
the
Discussion Required
This should facilitate debugging in some cases.