[Testing] Dockerized test suite #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobpenny
added
the
Testing
kongtiaowang
added
Passed Manual Tests
driusan
previously requested changes
Nov 22, 2016
driusan
previously requested changes
Nov 22, 2016
| @@ -0,0 +1,7 @@ | |||
| FROM php:7.0 | |||
There was a problem hiding this comment.
Can you just update the main Dockerfile? The default one should probably be updated to PHP7, there's no reason to maintain one for PHP5 anymore.
There was a problem hiding this comment.
Are you saying I can just overwrite the default Dockerfile and Dockerfile.MySQL with mine?
| @@ -0,0 +1,27 @@ | |||
| FROM mysql:5.7 | |||
There was a problem hiding this comment.
Is there any way for this to be combined with the existing Dockerfile.MySQL too?
| @@ -0,0 +1,38 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Can you update Travis to use these scripts instead of duplicating it?
(You'd have to make sure it exits with a non-zero status for any of the lint runs so that Travis will fail..)
There was a problem hiding this comment.
Sure I'll do that.
If we want to take the plunge we could use the Docker based testing in Travis too. I thought that might be too much change for one PR though.
There was a problem hiding this comment.
For what it's worth, a dockerized .travis.yml would look like:
language: php
sudo: required
services:
- docker
cache:
directories:
- vendor
env:
- TEST_SUITE=lint:javascript
- TEST_SUITE=lint:php
- TEST_SUITE=tests:unit
- TEST_SUITE=tests:integration
before_install:
# Ensure node version is up to date
- nvm install node
- npm install
install:
- composer install
script:
- npm run --silent $TEST_SUITE
This breaks the tests up into 4 builds: unit tests, integration tests, PHP linting, and JS linting.
jacobpenny
force-pushed
the
dockerized-test-suite
branch
2 times, most recently
from
95a5096
to
2025a05
Compare
|
Requested changes made |
Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite.
.click was not executing form submit and was causing the test to fail
jacobpenny
force-pushed
the
dockerized-test-suite
branch
from
2025a05
to
5560c43
Compare
alisterdev
pushed a commit
to alisterdev/Loris
that referenced
this pull request
Jan 20, 2017
* Removing spaces from test suite names Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite. * Skipping broken tests * Replacing .click with .submit .click was not executing form submit and was causing the test to fail * Add missing xsi:nil property to fixture * Allow a selenium host/port to be specified via config file * Add docker-based test suite and required scripts * Add note about creating Docker group * Rename Dockerfiles * Use linting scripts in .travis.yml
MounaSafiHarab
pushed a commit
to MounaSafiHarab/Loris
that referenced
this pull request
Jan 20, 2017
* Removing spaces from test suite names Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite. * Skipping broken tests * Replacing .click with .submit .click was not executing form submit and was causing the test to fail * Add missing xsi:nil property to fixture * Allow a selenium host/port to be specified via config file * Add docker-based test suite and required scripts * Add note about creating Docker group * Rename Dockerfiles * Use linting scripts in .travis.yml
taracampbell
pushed a commit
to taracampbell/Loris
that referenced
this pull request
Mar 9, 2017
* Removing spaces from test suite names Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite. * Skipping broken tests * Replacing .click with .submit .click was not executing form submit and was causing the test to fail * Add missing xsi:nil property to fixture * Allow a selenium host/port to be specified via config file * Add docker-based test suite and required scripts * Add note about creating Docker group * Rename Dockerfiles * Use linting scripts in .travis.yml
jstirling91
pushed a commit
to jstirling91/Loris
that referenced
this pull request
May 8, 2017
* Removing spaces from test suite names Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite. * Skipping broken tests * Replacing .click with .submit .click was not executing form submit and was causing the test to fail * Add missing xsi:nil property to fixture * Allow a selenium host/port to be specified via config file * Add docker-based test suite and required scripts * Add note about creating Docker group * Rename Dockerfiles * Use linting scripts in .travis.yml
kongtiaowang
pushed a commit
to kongtiaowang/Loris
that referenced
this pull request
Jan 31, 2018
* Removing spaces from test suite names Having spaces in test suite names makes it difficult to call phpunit from wrapper scripts, which are needed for the docker-based test suite. * Skipping broken tests * Replacing .click with .submit .click was not executing form submit and was causing the test to fail * Add missing xsi:nil property to fixture * Allow a selenium host/port to be specified via config file * Add docker-based test suite and required scripts * Add note about creating Docker group * Rename Dockerfiles * Use linting scripts in .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
README.mdincluded gives an overview of the requirements/features, please have a look there first. Also note that the first time you run the tests will take a while because it needs to download a few docker images.I tried not to make any changes that would affect existing workflows, however I did have to remove spaces from the test suite names in
phpunit.xmlin order to make some wrapper scripts I use work. Also, a dedicatedtest/config.xmlfile was added because it simplifies set up quite a bit.This P/R also contains some general test fixes that are needed when running the tests with
sandboxenabled (Travis has been running the tests with this disabled and was skipping some tests because of it).