[Core] Make Loris Version Visible To The Front End #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Feature
driusan
requested changes
Jan 4, 2017
| @@ -63,6 +63,7 @@ function tplFromRequest($param) | |||
| $tpl_data['currentyear'] = date('Y'); | |||
| $tpl_data['test_name'] = $TestName; | |||
| $tpl_data['subtest'] = $subtest; | |||
| $tpl_data['version'] = file_get_contents('../VERSION'); | |||
There was a problem hiding this comment.
This should probably explicitly be relative to the dir of main.php, not the cwd: __DIR__ . '../VERSION'
driusan
approved these changes
Jan 4, 2017
jstirling91
pushed a commit
to jstirling91/Loris
that referenced
this pull request
May 8, 2017
Version Number Now Visible In The Front End.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version Number Now Visible In The Front End.