[tools] CouchDB Importer Integrity not removing inactive candidates #2801
Conversation
gluneau
commented
May 12, 2017
gluneau
commented
- Delete documents if candidate is inactive
- Checking if sql result array is not empty before deleting
gluneau
added
the
Bug
tools/CouchDB_Confirm_Integrity.php
Outdated
| @@ -80,31 +81,40 @@ function run() | |||
| "VL" => $vl | |||
| ) | |||
| ); | |||
| $inactiveCandID = $this->SQLDB->pselectRow("SELECT * FROM candidate c WHERE c.Active='N' AND c.PSCID=:PID", array("PID" => $pscid)); | |||
There was a problem hiding this comment.
I don't see why this extra query is required over just adding Active='Y' (for both the session and candidate) to the query above just above it (that isn't showing up in the diff.)
gluneau
force-pushed
the
integrityNotRemoveingInactiveCandID
branch
from
18c95e4
to
b9a635b
Compare
|
@jstirling91 Please review and test as suggested by @driusan, Thank you. |
| if ($numActive[0]['count'] == '0') { | ||
| print "PSCID $pscid VL $vl is cancelled and has no active" | ||
|
|
||
| if (!array_key_exists('count', $numActive[0]) |
There was a problem hiding this comment.
@gluneau why do we need this !array_key_exists() ???
There was a problem hiding this comment.
to avoid printing stuff to the log. just answered myself
|
@jstirling91 Let me know when you can review and test. |
|
@driusan @jstirling91 Can we get this tested? |
|
@driusan @jstirling91 Please test. |
tools/CouchDB_Confirm_Integrity.php
Outdated
| $this->CouchDB->deleteDoc($row['id']); | ||
| } | ||
|
|
||
| if (!empty($sqlDB) && $sqlDB['Active'] != 'Y') { |
There was a problem hiding this comment.
This should be an 'else if' statement.
There was a problem hiding this comment.
Is that going to affect the functionality or just make it cleaner?
(I'm not sure what happens in our code if you try and delete an already deleted CouchDB doc.)
There was a problem hiding this comment.
I'm trying to handle the case of the last 'else' statement. Currently it'll still print "Nothing wrong with $row[id]!\n" even if it hit the first if case above.
gluneau
moved this from Needs Testing
to Author Needs To Incorporate Changes
in Code review 18.1
tools/CouchDB_Confirm_Integrity.php
Outdated
| $this->CouchDB->deleteDoc($row['id']); | ||
| } | ||
|
|
||
| if (!empty($sqlDB) && $sqlDB['Active'] != 'Y') { |
There was a problem hiding this comment.
I'm trying to handle the case of the last 'else' statement. Currently it'll still print "Nothing wrong with $row[id]!\n" even if it hit the first if case above.
|
Okay this github review system can be confusing |
…eau/Loris into integrityNotRemoveingInactiveCandID
|
@Jkat Please take a look at the change |
samirdas
added
the
Critical to release
gluneau
moved this from Author Needs To Incorporate Changes
to Needs Testing
in Code review 18.1
Jkat
added
the
Passed Manual Tests
ridz1208
moved this from Needs Testing
to Needs Senior Developer Review And Senior Developer Should Merge If Everything Is Fine So There's No Further States
in Code review 18.1
driusan
removed this from Needs Senior Developer Review And Senior Developer Should Merge If Everything Is Fine So There's No Further States
in Code review 18.1
