Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Forgot to update VERSION #2832

Merged
merged 2 commits into from May 26, 2017
Merged

[Core] Forgot to update VERSION #2832

merged 2 commits into from May 26, 2017

Conversation

Jkat
Copy link
Contributor

@Jkat Jkat commented May 24, 2017

So we released again without updating the VERSION file...so...17.0.4? 馃ぃ

@Jkat Jkat added Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Passed Manual Tests PR has undergone proper testing by at least one peer labels May 24, 2017
@Jkat Jkat added this to the 17.0 milestone May 24, 2017
VERSION Outdated
@@ -1 +1 @@
17.0.2
17.0.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 is already tagged, so shouldn't this update it to 4 so that the next one is correct rather than having the next one wrong too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about this as I was making my initial commit...hence my PR comment 馃槅

@driusan driusan merged commit ecefd86 into aces:17.0-dev May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta PR does something that organizes, upgrades, or manages the functionality of the codebase Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants