Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[document_repository] Rewrite and Reactify #3971

Merged
merged 111 commits into from
May 23, 2019
Merged

[document_repository] Rewrite and Reactify #3971

merged 111 commits into from
May 23, 2019

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Sep 21, 2018 •
edited
Loading

Rewrite and Reactify this module.

To test

It should be tested everything in the module based on the test plan.
todo: rewriting the test case.

newUI:
https://sketch.cloud/s/mOzgL

@kongtiaowang kongtiaowang added [branch] major Cleanup PR or issue introducing/requiring at least one clean-up operation Feature PR or issue introducing/requiring at least one new feature Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix UI PR or issue introducing/requiring improvements to the LORIS User Interface labels Sep 21, 2018
@kongtiaowang kongtiaowang changed the title [document_repository] Rewrite - Reactify [document_repository] Rewrite and Reactify Sep 21, 2018
@kongtiaowang kongtiaowang added the Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated label Sep 21, 2018
HenriRabalais
HenriRabalais previously requested changes Oct 1, 2018
View reviewed changes
Copy link
Collaborator

@HenriRabalais HenriRabalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First Round of Comments!

modules/document_repository/ajax/FileUpload.php Outdated Show resolved Hide resolved
modules/document_repository/ajax/FileUpload.php Outdated Show resolved Hide resolved
modules/document_repository/ajax/FileUpload.php Outdated Show resolved Hide resolved
modules/document_repository/ajax/FileUpload.php Outdated Show resolved Hide resolved
modules/document_repository/ajax/FileUpload.php Outdated Show resolved Hide resolved
modules/document_repository/jsx/editForm.js Show resolved Hide resolved
modules/document_repository/jsx/uploadForm.js Outdated Show resolved Hide resolved
modules/document_repository/jsx/uploadForm.js Show resolved Hide resolved
modules/document_repository/jsx/uploadForm.js Outdated Show resolved Hide resolved
modules/document_repository/php/edit.class.inc Outdated Show resolved Hide resolved
@johnsaigle
Copy link
Contributor

This should have a new .gitignore file in the js/ folder. See #3982 and #3891.

driusan
driusan requested changes May 21, 2019
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 places that look vulnerable to SQL injection attacks.

modules/document_repository/php/files.class.inc Outdated Show resolved Hide resolved
modules/document_repository/php/files.class.inc Outdated Show resolved Hide resolved
modules/document_repository/php/files.class.inc Outdated Show resolved Hide resolved
@driusan driusan added the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label May 22, 2019
@driusan driusan removed the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label May 22, 2019
@kongtiaowang kongtiaowang reopened this May 22, 2019
@kongtiaowang kongtiaowang reopened this May 22, 2019
@kongtiaowang kongtiaowang reopened this May 23, 2019
@driusan
Copy link
Collaborator

driusan commented May 23, 2019

Failing due to #4688

@kongtiaowang kongtiaowang reopened this May 23, 2019
@driusan driusan merged commit 7e836f8 into aces:21.0-release May 23, 2019
@driusan driusan mentioned this pull request May 27, 2019
Merged
1 task
nicolasbrossard pushed a commit to nicolasbrossard/Loris that referenced this pull request Jun 26, 2019
@kongtiaowang @nicolasbrossard
[document_repository] Rewrite and Reactify (aces#3971)
819be21 
Convert document repository to a React module rather than a smarty module.
@driusan driusan moved this from PR Sent to Done in Remove module/ajax directories Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paiva paiva paiva left review comments

@driusan driusan driusan approved these changes

@zaliqarosli zaliqarosli zaliqarosli approved these changes

@cmadjar cmadjar cmadjar left review comments

@johnsaigle johnsaigle johnsaigle left review comments

@HenriRabalais HenriRabalais HenriRabalais left review comments

@sruthymathew123 sruthymathew123 sruthymathew123 left review comments

Assignees

@kongtiaowang kongtiaowang

Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation Document at Release PR adds or changes a feature such that the wiki (or other documentation) must be updated Feature PR or issue introducing/requiring at least one new feature Passed Manual Tests PR has undergone proper testing by at least one peer UI PR or issue introducing/requiring improvements to the LORIS User Interface
Projects
No open projects
Remove module/ajax directories
Done
Milestone
21.0.0
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@kongtiaowang @johnsaigle @zaliqarosli @sruthymathew123 @Jkat @ridz1208 @driusan @cmadjar @HenriRabalais @paiva