Add make check target
#4002
Merged
Add make check target
#4002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapillonMcGill
approved these changes
Oct 22, 2018
PapillonMcGill
previously requested changes
Oct 22, 2018
This adds a "make check" target to perform basic unittests and does some minor refactoring of the makefile The target "make checkstatic" and "make unittests" are also added to make it easier to quickly run a smoke test.
driusan
added
Meta
driusan
added a commit
to driusan/Loris
that referenced
this pull request
Dec 19, 2018
I don't see any way the failures in aces#4002 could possibly be related to just moving around where things are called.
The unittests fail when invoking the exact same command and needs investigation
driusan
removed
the
"Help! I don't understand Travis!"
|
@PapillonMcGill Can you re-review? |
1 task
johnsaigle
reviewed
Dec 19, 2018
| @@ -51,7 +51,7 @@ class UserPermissions | |||
| function select($username) | |||
| { | |||
| // create DB object | |||
| $DB =& Database::singleton(); | |||
| $DB = \Database::singleton(); | |||
There was a problem hiding this comment.
Not relevant to this PR but also.... this is nice.
There was a problem hiding this comment.
Yeah, it was throwing a database exception on that line and I thought that might be the cause..
PapillonMcGill
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "make check" target to perform basic unittests and
does some minor refactoring of the makefile
The target "make checkstatic" and "make unittests" are also
added to make it easier to quickly run a smoke test.