Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean up] deletion of the full MINC header entry from parameter_file as not used anymore #4925

Merged
merged 1 commit into from Jul 22, 2019
Merged

[Clean up] deletion of the full MINC header entry from parameter_file as not used anymore #4925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...9_07_04_remove_header_row_from_parameter_file_and_convert_back_to_Value_field_to_text.sql
View file
Open in desktop
@@ -0,0 +1,3 @@
DELETE FROM parameter_file WHERE ParameterTypeID=(SELECT ParameterTypeID FROM parameter_type WHERE Name='header' AND SourceFrom='parameter_file');
DELETE FROM parameter_type WHERE Name='header' AND SourceFrom='parameter_file';
ALTER TABLE parameter_file MODIFY Value TEXT;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmadjar I don't know the kind of value that are there but any value longer that 64KB will be trunct to the 1st 64KB.

If there should not be any value longer than that after the delete, I approve this PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PapillonMcGill the insertion script is filtering any value longer than 1000 characters so moving it back to text is fine. The only exception was the 'header' which was crazy long and that we are getting rid of in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.