Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tools] Enable PHPCS for populate_visit_windows.php #5995

Closed
wants to merge 1 commit into from
Closed

[Tools] Enable PHPCS for populate_visit_windows.php #5995

wants to merge 1 commit into from

Conversation

johnsaigle
Copy link
Contributor

No description provided.

@johnsaigle johnsaigle added the Testing PR contains test plan or automated test code (or config files for Travis) label Jan 29, 2020
@johnsaigle johnsaigle added this to In progress in Check tools scripts using PHPCS via automation Jan 29, 2020
PapillonMcGill
PapillonMcGill reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@PapillonMcGill PapillonMcGill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebase

@johnsaigle johnsaigle added the Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch label Feb 6, 2020
@stale
Copy link

stale bot commented Apr 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. label Apr 3, 2020
@laemtl laemtl mentioned this pull request Jun 30, 2020
Merged
@laemtl
Copy link
Contributor

laemtl commented Jun 30, 2020

Replaced by #6793

@laemtl laemtl closed this Jun 30, 2020
Check tools scripts using PHPCS automation moved this from In progress to Done Jun 30, 2020
driusan pushed a commit that referenced this pull request Jul 9, 2020
@laemtl
[Tools] Enable PHPCS for populate_visit_windows.php (#6793)
ed6008e 
Co-authored-by: John Saigle <john.saigle@gmail.com>

Replaces #5995
laemtl added a commit to laemtl/Loris that referenced this pull request Jul 13, 2020
@laemtl
[Tools] Enable PHPCS for populate_visit_windows.php (aces#6793)
c4c2c1a 
Co-authored-by: John Saigle <john.saigle@gmail.com>

Replaces aces#5995
laemtl added a commit to laemtl/Loris that referenced this pull request Jul 16, 2020
@laemtl
[Tools] Enable PHPCS for populate_visit_windows.php (aces#6793)
64e7ba6 
Co-authored-by: John Saigle <john.saigle@gmail.com>

Replaces aces#5995
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
@laemtl @AlexandraLivadas
[Tools] Enable PHPCS for populate_visit_windows.php (aces#6793)
fb3b242 
Co-authored-by: John Saigle <john.saigle@gmail.com>

Replaces aces#5995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PapillonMcGill PapillonMcGill PapillonMcGill left review comments

Assignees
No one assigned
Labels
Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch Stale PR has had no activity. Should be triaged for review or possibly closed as low priority. Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnsaigle @laemtl @PapillonMcGill