Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[survey_accounts] Remove all traces of emails from the database #7248

Merged

Conversation

ridz1208
Copy link
Collaborator

Brief summary of changes

Removing all traces of stored emails in the database without affecting emailing functionality.

@ridz1208
Copy link
Collaborator Author

@zaliqarosli @jesscall can one of you test this on 21 ??

@zaliqarosli zaliqarosli self-assigned this Dec 18, 2020
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly!

@zaliqarosli zaliqarosli added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 22, 2020
@ridz1208
Copy link
Collaborator Author

@CamilleBeau did you find the source of your issues ? if not, we can have a call about it tomorrow

@CamilleBeau
Copy link
Contributor

@CamilleBeau did you find the source of your issues ? if not, we can have a call about it tomorrow

No I didn't yet. I'll slack you

@CamilleBeau
Copy link
Contributor

Everything looks good on CCNA

@driusan driusan merged commit 37c0196 into aces:21.0-release Dec 23, 2020
@ridz1208 ridz1208 added this to the 21.0.7 milestone Dec 23, 2020
driusan pushed a commit that referenced this pull request May 17, 2021
…7452)

Email column of participant_accounts was removed in #7248, but SurveyAccountsProvisioner is still selecting the removed column from the DB causing a 500 error.
driusan pushed a commit that referenced this pull request Feb 14, 2023
The Email column of the participant_accounts table was removed in #7248.
This PR cleans up the remaining references to that column, and removes from the schema/raisinbread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants